21077 - [DOGFOOD] TextEditorAppshell.xul is missing on win32

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P1)

Description

[sujay]

using 12/7 build(1999120708) of apprunner on Windows only:

1) launch apprunner
2) launch editor
3) Debug | Plaintext editor

nothing comes up. In console you see this message:

Error: can't load
resource:///chrome/editor/content/default/TextEditorAppshell.xul

happens on Windows only.

Comment 1

[rubydoo123]

The TextEditorAppshell.xul file is not in the directory, it isn't getting
loaded. Charley, do you have any idea as to why it isn't getting loaded?

Comment 2

[Charles Manske]

It's not supposed to be distributed with an optimized build.
It's only for debug testing only - that's why it's on the debug menu.
Does anyone think giving access to *should* be included at least in "dogfood"
distribution?

Comment 3

[sujay]

Then why is it getting loaded on Mac and Linux??? I'm confused....

Comment 4

[rubydoo123]

the debug menu menu will eventually go away on the commercial build - Charley,
do you know when that will happen?

Comment 5

[Akkana Peck]

The plaintext editor window is very useful for testing, and is certainly more
usable than some of the fairly technical stuff we have in the debug menu.  I
think we should include it in optimized builds, at least until the debug menu
goes away (perhaps at beta time).

Comment 6

[rubydoo123]

as long as the debug is there, the options, including the plaintext editor,
should be available. Charley, can you hook it back up?

Comment 7

[leger]

Plain text editor is not critical.  If this functionality is critical to daily
development with no workaround, please let us know. Putting on the PDT- radar.

Comment 8

[sujay]

the issue here is inconsistency. lets either yank it from all 3 platforms
or lets get it working on all "3" platforms.

Comment 9

[rubydoo123]

moving to m13

Comment 10

[Charles Manske]

Editor group discussion has determined that we really want to include the
plain text editor for dogfood testing. To make this work in windows is simply a
matter of including a file in the installer list.
Here's the diff:
Index: packages-win
===================================================================
RCS file: /cvsroot/mozilla/xpinstall/packager/packages-win,v
retrieving revision 1.22
diff -r1.22 packages-win
165,166c165,167
< -bin\chrome\editor\content\default\TextEditorAppShell.xul
---
> ;Include this for "debug" testing - remove for actual beta release:
> ;-bin\chrome\editor\content\default\TextEditorAppShell.xul

We would also need this change so we bring up a blank page instead of the
pre-filled test page:
Index: EditorCommands.js
===================================================================
RCS file: /cvsroot/mozilla/editor/ui/composer/content/EditorCommands.js,v
retrieving revision 1.102
diff -r1.102 EditorCommands.js
369c369
<  "chrome://editor/content/EditorInitPagePlain.html");
---
>  "about:blank");

Could we please reconsider PDT status to allow us to check this in?

Comment 11

[Charles Manske]

Removing [PDT-] to trigger reconsideration by PDT team.

Comment 12

[leger]

Putting on PDT+ radar.

Comment 13

[Charles Manske]

Checked in 12/9

Comment 14

[sujay]

will verify in 12/10 build.

Comment 15

[sujay]

verified in 12/10 build.