Bogus comparison in nsCSSParserImpl::ParseURL

RESOLVED FIXED

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: jag (Peter Annema), Assigned: jag (Peter Annema))

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
 
(Assignee)

Updated

14 years ago
Status: NEW → ASSIGNED
Summary: Bogus comparison in nsCSSParser::ParseURL → Bogus comparison in nsCSSParserImpl::ParseURL
(Assignee)

Comment 1

14 years ago
Created attachment 126593 [details] [diff] [review]
Fix comparison, clean up code a little
(Assignee)

Comment 2

14 years ago
See bug 98786.
(Assignee)

Comment 3

14 years ago
Comment on attachment 126593 [details] [diff] [review]
Fix comparison, clean up code a little

Alternatively I guess I could say something like |if (absURL.IsEmpty()) absURL
= tk->mIdent;| instead of this NS_FAILED(rv) trick. Preference?
Attachment #126593 - Flags: review?(jst)
Component: DOM Style → Style System
Comment on attachment 126593 [details] [diff] [review]
Fix comparison, clean up code a little

Yeah, IMO using absURL.IsEmpty() in stead of rv here would be cleaner.

r=jst either way.
Attachment #126593 - Flags: review?(jst) → review+

Comment 5

14 years ago
Comment on attachment 126593 [details] [diff] [review]
Fix comparison, clean up code a little

sr=me; I think I prefer the rv check.
Attachment #126593 - Flags: superreview+
(Assignee)

Comment 6

14 years ago
I've gone with the rv check (though I should be able to depend on absURL not
being touched if NS_FAILED(rv)).

Comment 7

14 years ago
> though I should be able to depend on absURL not being touched

Necko functions explicitly do not guarantee this; just ask darin.
(Assignee)

Comment 8

14 years ago
Cool, so check on rv it is then.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.