If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

nsIHelperAppLauncherDialog::ShowProgressDialog unused

RESOLVED FIXED in mozilla1.5alpha

Status

Core Graveyard
File Handling
P1
normal
RESOLVED FIXED
14 years ago
a year ago

People

(Reporter: Biesinger, Assigned: Biesinger)

Tracking

Trunk
mozilla1.5alpha
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

lxr shows no caller of this function, only declarations/impls

now, this function is the only user of nsProgressDlg.{js,xul}:
http://lxr.mozilla.org/seamonkey/search?string=nsprogressdlg

so that can be removed as well
Created attachment 126823 [details] [diff] [review]
patch
Attachment #126823 - Flags: review?(bzbarsky)
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.5alpha
Comment on attachment 126823 [details] [diff] [review]
patch

r=me assuming you tested carefully and can still get a progress dialog when
downloading files or opening them in helpers... ;)
Attachment #126823 - Flags: review?(bzbarsky) → review+
Comment on attachment 126823 [details] [diff] [review]
patch

bz: Yes, I did verify that I still get progress windows :)
Attachment #126823 - Flags: superreview?(darin)

Comment 4

14 years ago
Comment on attachment 126823 [details] [diff] [review]
patch

sr=darin

are you sure someone didn't intend to use this for something?  IOW, is this
really dead code?  perhaps it would be wise to drop a line to whomever added
this code to the tree.
Attachment #126823 - Flags: superreview?(darin) → superreview+
well this dialog was used once:
1.61 	law%netscape.com	May 3 2001	 	Bug 52454; fix lots of external app service
bugs and enable new helper app dlg; r=pchen@netscape.com, sr=mscott@netscape.com
(law was also the one who initially checked in nsProgressDlg)

This checkin changed it so that ->ShowProgressDialog (and therefore
nsProgressDlg) was no longer used:
1.131	law%netscape.com	Feb 20 2002	 	Bug 27609; change exthandler to use new
progress dialog and properly report i/o errors; r=bzbarsky, sr=mscott

In this context, see bug 27609 comment 47:
[...] (the ones named nsProgressDlg.* are obsolescent) [...]

So, the author of this code knew all about this.
checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED

Comment 7

14 years ago
Um, this seems to have killed the camino build.

src/embedding/CHBrowserService.mm:294: no `nsresult
CHBrowserService::ShowProgressDialog(nsIHelperAppLauncher*, nsISupports*)'
member function declared in class `CHBrowserService'
Checked in same removal change to camino/src/embedding/CHBrowserService.mm
(which SeaMonkey lxr does not show).  I left
chimera/src/embedding/CHBrowserService.mm be, since it should be obsolete (and
is a closed CVS partition anyway).
oh, right... I'm really sorry about that, I only checked seamonkey lxr. bz,
thanks for fixing!
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.