[FIXr] random array cleanup in exthandler

RESOLVED FIXED

Status

Core Graveyard
File Handling
RESOLVED FIXED
15 years ago
2 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Just a twinge of ugly code in my side.
Attachment #126801 - Flags: superreview?(alecf)
Attachment #126801 - Flags: review?(cbiesinger)
Comment on attachment 126801 [details] [diff] [review]
patch

+  nsILocalFile* localFile;

hm... why are you declaring this variable outside of the loop?
Comment on attachment 126801 [details] [diff] [review]
patch

+  nsILocalFile* localFile;

hm... why are you declaring this variable outside of the loop?
Because that's where the original code had it, if you note....
Comment on attachment 126801 [details] [diff] [review]
patch

r=biesi if you move the "+  nsILocalFile* localFile;" declaration when this
variable is first used, to not make it look like this variable is used outside
the  |for|
Attachment #126801 - Flags: review?(cbiesinger) → review+

Comment 6

15 years ago
Comment on attachment 126801 [details] [diff] [review]
patch

nice. sr=alecf
Attachment #126801 - Flags: superreview?(alecf) → superreview+
Summary: [FIX] random array cleanup in exthandler → [FIXr] random array cleanup in exthandler
Checked in.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.