If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Double-quote munger breaks word wrapping

RESOLVED FIXED

Status

Other Applications
ChatZilla
--
minor
RESOLVED FIXED
14 years ago
9 years ago

People

(Reporter: James Ross, Assigned: Gijs)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cz-0.9.84])

Attachments

(3 obsolete attachments)

(Reporter)

Description

14 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624

When someone says a line with a large number of ` or ' characters, they are
mungered into the Unicode open and close double-quotes, but it then prevents any
word wrapping from occuring in the quotes.

Reproducible: Always

Steps to Reproduce:
1. Open ChatZilla.
2. Type "/echo " and a large number of '-characters. Increase as needed until
width of window is reached.

Actual Results:  
Client are gets a horizontal scroll bar.

Expected Results:  
Quotes should wrap just like any other 'long word'.

This problem does not occur when the 'Double quotes' munger is turned off.

The only real problem here is the horizontal scroll bar, which makes reading the
contents of a channel quite hard. :)
Product: Core → Other Applications
(Reporter)

Updated

12 years ago
OS: Windows 2000 → All
Hardware: PC → All

Comment 1

12 years ago
Control characters also seem to confuse the wrapper, e.g.
~0x1b[6~0x1b[6~0x1b[6~0x1b[6~0x1b[6~0x1b[6~0x1b[6~0x1b[6~0x1b[6~0x1b[6~0x1b[6~0x1b[6~0x1b[6~/who
(the ~0x1b displays inside its own set of []s which don't copy & paste)
(Assignee)

Comment 2

9 years ago
Created attachment 341681 [details] [diff] [review]
Patch

I expect this doesn't fix the case Neil describes, but it should fix the quote case (does in my testing). And it saves us a bunch of lines by using the const we define in static.js for the munger cruft. Ugh. :-(
Assignee: rginda → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #341681 - Flags: review?(silver)
(Assignee)

Comment 3

9 years ago
Created attachment 341690 [details] [diff] [review]
Patch v2 [checked in]

Better fixing of the namespace cruft.
Attachment #341681 - Attachment is obsolete: true
Attachment #341690 - Flags: review?(silver)
Attachment #341681 - Flags: review?(silver)
(Reporter)

Comment 4

9 years ago
Comment on attachment 341690 [details] [diff] [review]
Patch v2 [checked in]

Can you do a follow for showCtrlChar() then?
Attachment #341690 - Flags: review?(silver) → review+
(Assignee)

Comment 5

9 years ago
Comment on attachment 341690 [details] [diff] [review]
Patch v2 [checked in]

Checking in mozilla/extensions/irc/js/lib/utils.js;
/cvsroot/mozilla/extensions/irc/js/lib/utils.js,v  <--  utils.js
new revision: 1.73; previous revision: 1.72
done
Checking in mozilla/extensions/irc/xul/content/mungers.js;
/cvsroot/mozilla/extensions/irc/xul/content/mungers.js,v  <--  mungers.js
new revision: 1.17; previous revision: 1.16
done
Checking in mozilla/extensions/irc/xul/content/static.js;
/cvsroot/mozilla/extensions/irc/xul/content/static.js,v  <--  static.js
new revision: 1.287; previous revision: 1.286
done
Checking in mozilla/extensions/irc/xul/lib/munger.js;
/cvsroot/mozilla/extensions/irc/xul/lib/munger.js,v  <--  munger.js
new revision: 1.28; previous revision: 1.27
done
Attachment #341690 - Attachment description: Patch v2 → Patch v2 [checked in]
Attachment #341690 - Attachment is obsolete: true
(Assignee)

Updated

9 years ago
Whiteboard: [cz-0.9.84]
(Assignee)

Comment 6

9 years ago
Created attachment 342290 [details] [diff] [review]
[checked in] Same patch for ctrl chars

I haven't tested this yet, but it should pretty much work the same way...
Attachment #342290 - Flags: review?(silver)
(Reporter)

Updated

9 years ago
Attachment #342290 - Flags: review?(silver) → review+
(Assignee)

Comment 7

9 years ago
Checking in mozilla/extensions/irc/xul/content/mungers.js;
/cvsroot/mozilla/extensions/irc/xul/content/mungers.js,v  <--  mungers.js
new revision: 1.18; previous revision: 1.17
done
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Attachment #342290 - Attachment description: Same patch for ctrl chars → [checked in] Same patch for ctrl chars
Attachment #342290 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.