void nsCertTree::InitCompareHash doesn't check the return value of PL_DHashTableInit

RESOLVED FIXED

Status

Core Graveyard
Security: UI
--
minor
RESOLVED FIXED
15 years ago
2 years ago

People

(Reporter: timeless, Assigned: Stephane Saux)

Tracking

Other Branch
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

15 years ago
This is a code inspection bug.

QA:
To verify that this bug is fixed, make sure that all callers in of 
PL_DHashTableInit in the indicated class/file check and handle a failure return 
result.
To verify that this bug is invalid, simply verify (e.g. with lxr) that 
PL_DHashTableInit is no longer used by the indicated class/file.

PL_DHashTableInit returns a PRBool indicating whether it succeeded. 
PL_DHashTableInit *can* fail. Code can not assume that table->ops or table-
>data will be null (in fact it probably will not be), although in all 
likelyhood table->entryStore will be null it probably isn't safe to assume this.

Code at time of bug filing:

 135 void nsCertTree::InitCompareHash()
 136 {
 137   ClearCompareHash();
 138   PL_DHashTableInit(&mCompareCache, &gMapOps, nsnull,
 139                     sizeof(CompareCacheHashEntry), 128);
 140 }
(Reporter)

Comment 1

15 years ago
Created attachment 128529 [details] [diff] [review]
patch
(Reporter)

Updated

15 years ago
Attachment #128529 - Flags: superreview?(bzbarsky)
Attachment #128529 - Flags: review?(kaie)
Attachment #128529 - Flags: superreview?(bzbarsky) → superreview+

Comment 2

15 years ago
Comment on attachment 128529 [details] [diff] [review]
patch

r=kaie
Thanks for the patch
Attachment #128529 - Flags: review?(kaie) → review+
(Reporter)

Comment 3

15 years ago
checked in
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
(Reporter)

Updated

14 years ago
Component: Security: UI → Security: UI
Product: PSM → Core
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.