Closed Bug 211332 Opened 21 years ago Closed 21 years ago

Remove unused files in mailnews/base/prefs/resources

Categories

(SeaMonkey :: MailNews: Account Configuration, defect)

Product:
SeaMonkey
Component:
MailNews: Account Configuration
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: pkwarren, Assigned: pkwarren)

References

Details

Attachments

(1 file)

Patch v1
76.11 KB, patch
sspitzer
: review+
Details | Diff | Splinter Review 
I have found some unused files in mailnews/base/prefs/resources that don't seem
to be referenced anywhere. These are confusing because it is hard to tell which
code needs to be modified when dealing with the Account Wizard. I have included
files referenced in Bug 72434 which are unused as well:

mozilla/mailnews/base/prefs/resources/content/aw-accname.xul
mozilla/mailnews/base/prefs/resources/content/aw-accounttype.xul
mozilla/mailnews/base/prefs/resources/content/aw-done.xul
mozilla/mailnews/base/prefs/resources/content/aw-identity.xul
mozilla/mailnews/base/prefs/resources/content/aw-login.xul
mozilla/mailnews/base/prefs/resources/content/aw-newsserver.xul
mozilla/mailnews/base/prefs/resources/content/aw-server.xul
mozilla/mailnews/base/prefs/resources/content/aw-wizardAdapter.js
mozilla/mailnews/base/prefs/resources/content/pref-advanced_overlay.xul
mozilla/mailnews/base/prefs/resources/content/pref-appearance_overlay.xul
mozilla/mailnews/base/prefs/resources/content/pref-tree_overlay.xul

mozilla/mailnews/base/prefs/resources/locale/en-US/aw-accname.dtd
mozilla/mailnews/base/prefs/resources/locale/en-US/aw-accounttype.dtd
mozilla/mailnews/base/prefs/resources/locale/en-US/aw-done.dtd
mozilla/mailnews/base/prefs/resources/locale/en-US/aw-email.dtd
mozilla/mailnews/base/prefs/resources/locale/en-US/aw-identity.dtd
mozilla/mailnews/base/prefs/resources/locale/en-US/aw-login.dtd
mozilla/mailnews/base/prefs/resources/locale/en-US/aw-mailtype.dtd
mozilla/mailnews/base/prefs/resources/locale/en-US/aw-server.dtd
mozilla/mailnews/base/prefs/resources/locale/en-US/pref-diskspace.dtd
No longer blocks: 72434
*** Bug 72434 has been marked as a duplicate of this bug. ***
Taking bug.
Assignee: sspitzer → pkw
Status: NEW → ASSIGNED
Summary: Removed unused files in mailnews/base/prefs/resources → Remove unused files in mailnews/base/prefs/resources
Attached patch Patch v1 — — Splinter Review 
Remove all files listed above as well as the matching .dtd files in
l10n/langpacks.
Attachment #126918 - Flags: review?(sspitzer)
Comment on attachment 126918 [details] [diff] [review]
Patch v1

hey philip, so for the delay.

good catch, I bet this is all stale, from when we converted the account wizard
from this way to use the <wizard> tag.

assuming you tested, r/sr=sspitzer@mozilla.org
Attachment #126918 - Flags: review?(sspitzer) → review+
Fixed.

Checking in mailnews/jar.mn;
/cvsroot/mozilla/mailnews/jar.mn,v  <--  jar.mn
new revision: 1.63; previous revision: 1.62
done
Removing mailnews/base/prefs/resources/content/aw-accname.xul;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/aw-accname.xul,v  <-- 
aw-accname.xul
new revision: delete; previous revision: 1.33
done
Removing mailnews/base/prefs/resources/content/aw-accounttype.xul;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/aw-accounttype.xul,v  <--
 aw-accounttype.xul
new revision: delete; previous revision: 1.42
done
Removing mailnews/base/prefs/resources/content/aw-done.xul;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/aw-done.xul,v  <-- 
aw-done.xul
new revision: delete; previous revision: 1.34
done
Removing mailnews/base/prefs/resources/content/aw-identity.xul;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/aw-identity.xul,v  <-- 
aw-identity.xul
new revision: delete; previous revision: 1.38
done
Removing mailnews/base/prefs/resources/content/aw-login.xul;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/aw-login.xul,v  <-- 
aw-login.xul
new revision: delete; previous revision: 1.39
done
Removing mailnews/base/prefs/resources/content/aw-newsserver.xul;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/aw-newsserver.xul,v  <--
 aw-newsserver.xul
new revision: delete; previous revision: 1.20
done
Removing mailnews/base/prefs/resources/content/aw-server.xul;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/aw-server.xul,v  <-- 
aw-server.xul
new revision: delete; previous revision: 1.43
done
Removing mailnews/base/prefs/resources/content/aw-wizardAdapter.js;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/aw-wizardAdapter.js,v 
<--  aw-wizardAdapter.js
new revision: delete; previous revision: 1.7
done
Removing mailnews/base/prefs/resources/content/pref-advanced_overlay.xul;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/pref-advanced_overlay.xul,v
 <--  pref-advanced_overlay.xul
new revision: delete; previous revision: 1.5
done
Removing mailnews/base/prefs/resources/content/pref-appearance_overlay.xul;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/pref-appearance_overlay.xul,v
 <--  pref-appearance_overlay.xul
new revision: delete; previous revision: 1.5
done
Removing mailnews/base/prefs/resources/content/pref-tree_overlay.xul;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/pref-tree_overlay.xul,v 
<--  pref-tree_overlay.xul
new revision: delete; previous revision: 1.4
done
Removing mailnews/base/prefs/resources/locale/en-US/aw-accname.dtd;
/cvsroot/mozilla/mailnews/base/prefs/resources/locale/en-US/aw-accname.dtd,v 
<--  aw-accname.dtd
new revision: delete; previous revision: 1.5
done
Removing mailnews/base/prefs/resources/locale/en-US/aw-accounttype.dtd;
/cvsroot/mozilla/mailnews/base/prefs/resources/locale/en-US/aw-accounttype.dtd,v
 <--  aw-accounttype.dtd
new revision: delete; previous revision: 1.8
done
Removing mailnews/base/prefs/resources/locale/en-US/aw-done.dtd;
/cvsroot/mozilla/mailnews/base/prefs/resources/locale/en-US/aw-done.dtd,v  <-- 
aw-done.dtd
new revision: delete; previous revision: 1.13
done
Removing mailnews/base/prefs/resources/locale/en-US/aw-email.dtd;
/cvsroot/mozilla/mailnews/base/prefs/resources/locale/en-US/aw-email.dtd,v  <--
 aw-email.dtd
new revision: delete; previous revision: 1.4
done
Removing mailnews/base/prefs/resources/locale/en-US/aw-identity.dtd;
/cvsroot/mozilla/mailnews/base/prefs/resources/locale/en-US/aw-identity.dtd,v 
<--  aw-identity.dtd
new revision: delete; previous revision: 1.8
done
Removing mailnews/base/prefs/resources/locale/en-US/aw-login.dtd;
/cvsroot/mozilla/mailnews/base/prefs/resources/locale/en-US/aw-login.dtd,v  <--
 aw-login.dtd
new revision: delete; previous revision: 1.10
done
Removing mailnews/base/prefs/resources/locale/en-US/aw-mailtype.dtd;
/cvsroot/mozilla/mailnews/base/prefs/resources/locale/en-US/aw-mailtype.dtd,v 
<--  aw-mailtype.dtd
new revision: delete; previous revision: 1.3
done
Removing mailnews/base/prefs/resources/locale/en-US/aw-server.dtd;
/cvsroot/mozilla/mailnews/base/prefs/resources/locale/en-US/aw-server.dtd,v  <--
 aw-server.dtd
new revision: delete; previous revision: 1.18
done
Removing mailnews/base/prefs/resources/locale/en-US/pref-diskspace.dtd;
/cvsroot/mozilla/mailnews/base/prefs/resources/locale/en-US/pref-diskspace.dtd,v
 <--  pref-diskspace.dtd
new revision: delete; previous revision: 1.7
done
Removing l10n/langpacks/en-DE/chrome/en-DE/messenger/locale/aw-accname.dtd;
/cvsroot/mozilla/l10n/langpacks/en-DE/chrome/en-DE/messenger/locale/aw-accname.dtd,v
 <--  aw-accname.dtd
new revision: delete; previous revision: 1.1.1.1
done
Removing l10n/langpacks/en-DE/chrome/en-DE/messenger/locale/aw-accounttype.dtd;
/cvsroot/mozilla/l10n/langpacks/en-DE/chrome/en-DE/messenger/locale/aw-accounttype.dtd,v
 <--  aw-accounttype.dtd
new revision: delete; previous revision: 1.1.1.1
done
Removing l10n/langpacks/en-DE/chrome/en-DE/messenger/locale/aw-done.dtd;
/cvsroot/mozilla/l10n/langpacks/en-DE/chrome/en-DE/messenger/locale/aw-done.dtd,v
 <--  aw-done.dtd
new revision: delete; previous revision: 1.1.1.1
done
Removing l10n/langpacks/en-DE/chrome/en-DE/messenger/locale/aw-email.dtd;
/cvsroot/mozilla/l10n/langpacks/en-DE/chrome/en-DE/messenger/locale/aw-email.dtd,v
 <--  aw-email.dtd
new revision: delete; previous revision: 1.1.1.1
done
Removing l10n/langpacks/en-DE/chrome/en-DE/messenger/locale/aw-identity.dtd;
/cvsroot/mozilla/l10n/langpacks/en-DE/chrome/en-DE/messenger/locale/aw-identity.dtd,v
 <--  aw-identity.dtd
new revision: delete; previous revision: 1.1.1.1
done
Removing l10n/langpacks/en-DE/chrome/en-DE/messenger/locale/aw-login.dtd;
/cvsroot/mozilla/l10n/langpacks/en-DE/chrome/en-DE/messenger/locale/aw-login.dtd,v
 <--  aw-login.dtd
new revision: delete; previous revision: 1.1.1.1
done
Removing l10n/langpacks/en-DE/chrome/en-DE/messenger/locale/aw-mailtype.dtd;
/cvsroot/mozilla/l10n/langpacks/en-DE/chrome/en-DE/messenger/locale/aw-mailtype.dtd,v
 <--  aw-mailtype.dtd
new revision: delete; previous revision: 1.1.1.1
done
Removing l10n/langpacks/en-DE/chrome/en-DE/messenger/locale/aw-server.dtd;
/cvsroot/mozilla/l10n/langpacks/en-DE/chrome/en-DE/messenger/locale/aw-server.dtd,v
 <--  aw-server.dtd
new revision: delete; previous revision: 1.1.1.1
done
Removing l10n/langpacks/en-DE/chrome/en-DE/messenger/locale/pref-diskspace.dtd;
/cvsroot/mozilla/l10n/langpacks/en-DE/chrome/en-DE/messenger/locale/pref-diskspace.dtd,v
 <--  pref-diskspace.dtd
new revision: delete; previous revision: 1.2
done
Removing l10n/langpacks/en-GB/chrome/en-GB/messenger/locale/aw-accname.dtd;
/cvsroot/mozilla/l10n/langpacks/en-GB/chrome/en-GB/messenger/locale/aw-accname.dtd,v
 <--  aw-accname.dtd
new revision: delete; previous revision: 1.1.1.1
done
Removing l10n/langpacks/en-GB/chrome/en-GB/messenger/locale/aw-accounttype.dtd;
/cvsroot/mozilla/l10n/langpacks/en-GB/chrome/en-GB/messenger/locale/aw-accounttype.dtd,v
 <--  aw-accounttype.dtd
new revision: delete; previous revision: 1.1.1.1
done
Removing l10n/langpacks/en-GB/chrome/en-GB/messenger/locale/aw-done.dtd;
/cvsroot/mozilla/l10n/langpacks/en-GB/chrome/en-GB/messenger/locale/aw-done.dtd,v
 <--  aw-done.dtd
new revision: delete; previous revision: 1.1.1.1
done
Removing l10n/langpacks/en-GB/chrome/en-GB/messenger/locale/aw-email.dtd;
/cvsroot/mozilla/l10n/langpacks/en-GB/chrome/en-GB/messenger/locale/aw-email.dtd,v
 <--  aw-email.dtd
new revision: delete; previous revision: 1.1.1.1
done
Removing l10n/langpacks/en-GB/chrome/en-GB/messenger/locale/aw-identity.dtd;
/cvsroot/mozilla/l10n/langpacks/en-GB/chrome/en-GB/messenger/locale/aw-identity.dtd,v
 <--  aw-identity.dtd
new revision: delete; previous revision: 1.1.1.1
done
Removing l10n/langpacks/en-GB/chrome/en-GB/messenger/locale/aw-login.dtd;
/cvsroot/mozilla/l10n/langpacks/en-GB/chrome/en-GB/messenger/locale/aw-login.dtd,v
 <--  aw-login.dtd
new revision: delete; previous revision: 1.1.1.1
done
Removing l10n/langpacks/en-GB/chrome/en-GB/messenger/locale/aw-mailtype.dtd;
/cvsroot/mozilla/l10n/langpacks/en-GB/chrome/en-GB/messenger/locale/aw-mailtype.dtd,v
 <--  aw-mailtype.dtd
new revision: delete; previous revision: 1.1.1.1
done
Removing l10n/langpacks/en-GB/chrome/en-GB/messenger/locale/aw-server.dtd;
/cvsroot/mozilla/l10n/langpacks/en-GB/chrome/en-GB/messenger/locale/aw-server.dtd,v
 <--  aw-server.dtd
new revision: delete; previous revision: 1.1.1.1
done
Removing l10n/langpacks/en-GB/chrome/en-GB/messenger/locale/pref-diskspace.dtd;
/cvsroot/mozilla/l10n/langpacks/en-GB/chrome/en-GB/messenger/locale/pref-diskspace.dtd,v
 <--  pref-diskspace.dtd
new revision: delete; previous revision: 1.2
done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: