211461 - Chatzilla doesnt connect when used as a tab in Firefox

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, enhancement)

Description

[Samir L. Boulema]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030626 Mozilla Firebird/0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030626 Mozilla Firebird/0.6

When you use Chatzilla in firebird as a tab by typing
chrome://chatzilla/content/ into the adressbar then chatzilla wont connect to
any server. it will just hang at the first attempt and never connect. Bu twhen
you run chatzilla by typing irc://irc.efnet.org thus opening its own window then
it will connect without a problem.

Reproducible: Always

Steps to Reproduce:
1. Type chrome://chatzilla/content/ into firebird
2. Try to connect to server
3.

Actual Results:  
chatzilla doesnt connect

Expected Results:  
chatzilla connects to the server

Comment 1

[Samuel Sieb]

This is not a supported way to use chatzilla.

Comment 2

[Samir L. Boulema]

hmmm but on the more info page on the extensionroom that way was given as a
possibility. so its a bit weird if it isnt working then :S but nevermind then i
will use the extension the normal way. but i hope it will be possible in the
future cause tht would make the extension so much better.

Comment 3

[Robert Ginda]

The chatzilla 0.9.x branch has landed on the trunk and should be available in
tomorrow's nightly build.  If you believe this bug has not actually been fixed,
please repoen it.

Comment 4

[Samir L. Boulema]

wil download the new chatzilla build asap to see if this bug is fixed :)

Comment 5

[Samir L. Boulema]

it doesnt work with chatzilla 0.9.28 it doesnt connect and the menus are very
weird, see screenshot for example :(

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030814 Mozilla
Firebird/0.6.1+

Comment 6

[Samir L. Boulema]

Attachment: screenshot of the menu problem.

chatzilla used in a tab, cant connect and the menus look weird

Comment 7

[Samir L. Boulema]

reopening this bug, cause its not fixed yet will keep an eye on the chatzilla
builds to see if it changes...

Comment 8

[Jeff Walden [:Waldo]]

Is this still a problem?

Comment 9

[Samir L. Boulema]

yep this bug is still alive with firefox 0.8 (20040209) and chatzilla 0.9.59p

Comment 10

[James Ross]

Attachment: Stops re-entrancy in the load/init code.

This doesn't make it work completely - dropping irc: URLs on the tab caused a
new, standalone ChatZilla window to open - but it connected and worked enough
to join a channel and talk. We're getting there. :)

Comment 11

[Samir L. Boulema]

Nice there is finally a break through :D

Comment 12

[Rick Kukiela]

I would like to add that I would like this bug to be fixed as i could use this
feature!

Comment 13

[James Ross]

Attachment: Return early if already inited client.

This is, I think, functionally equivelant to the previous patch, but is much
neater. :)

Comment 14

[Samuel Sieb]

Comment on attachment 143073 [details] [diff] [review]
Return early if already inited client.

You need to check for "initialized in client" as well to avoid strict warnings.
r=me with that

Comment 15

[James Ross]

Comment on attachment 143073 [details] [diff] [review]
Return early if already inited client.

Checked in.

Comment 16

[Samir L. Boulema]

"checked in" 

so will that mean that the next chatzilla builds will work this way :)

Comment 17

[James Ross]

You can either get 0.9.61 from http://www.hacksrus.com/~ginda/chatzilla/ or wait
for the next nightly Mozilla build. Both will have this patch in.

Comment 18

[Samir L. Boulema]

Nice its working :D
Now im only waiting for the firefox build of chatzilla 0.9.61 (0.9.61p) and then
im a happy :)

Comment 19

[James Ross]

--> FIXED.

ChatZilla does now connect to servers when used in a tab, however, many other
issues exist. This bug I believe was just for the basic connecting issue.