21182 - [PP][DOGFOOD] Mac commercial installer - installs the wrong file.

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect, P3)

Description

[pmock]

Build Date & Platform Bug Found:
 MacOS commercial seamonkey build 1999-12-08-08-m12 installed on G3/400 OS 8.6

Overview Description:
 The Mac installer program, NsMacInstaller-m12.sea.bin, is installing different
file than what is being uncompressed from the Netscape5-mac-m12.sea.bin.  When
I launch seamonkey that was installed by Mac installer, the build id that
displays 1999-12-07-16.  When I launch seamonkey that was uncompressed from
Netscape5, it displays the build id 1999-12-08-08.

In addition, if I compare the files that was installed on the hard drive, the
files installed by the mac installer has some files dated from today and from
yesterday.  The netscape5 files are all dated from today.

I downloaded the files from these url:
ftp://sweetlou/products/client/seamonkey/macos/8.x/ppc/1999-12-08-08-M12/NSMacIn
staller-M12.sea.bin

ftp://sweetlou/products/client/seamonkey/macos/8.x/ppc/1999-12-08-08-M12/netscap
e5-mac-M12.sea.bin

Steps to Reproduce:
1) Download todays Mac commercial Installer, NSMacInstaller-M12.sea.bin
2) Run the installer program
3) Migrate a profile when prompted
   I migrated my own profile
4) Look at the build id in the browser.
   It reads 1999-12-07-16.

Actual Results:
 After running the Mac Installer, the build id in the browser reads
1999-12-07-16 while the browser from the netscape5 binary reads 1999-12-08-08.

Expected Results:
 The installer program should install the same files that your have gotton if
you downloaded the netscape5 binary and uncompressed it.

Additional Builds and Platforms Tested On:
In yesterday Mac respin build 1999-12-07-16, the Mac Installer appears to work
fine.

Additional Information:
 In my tests, I deleted my moz registry and existing seamonkey profile before
each tests.  I tested the mac installer twice and I get the same results.

I spoke with Karen Huang and she downloaded and is using the Netscape5 binary.

Comment 1

[leger]

Putting on the PDT+ radar.

Comment 2

[Grace Bush]

I installed using NSMacInstaller and files did show 12/8 dates.  However I
crashed on startup-before getting to ProfileManager.  The last error message was
'the app ASEncoder has unexpectedly quit....'
I also did a compare between the files installed here and the ones installed
when using the netscape-mac-M12.sea.bin
I will attach

Comment 3

[Grace Bush]

Attachment: log from Macsbugs

Comment 4

[Grace Bush]

Attachment: comparison of files of installer vs .bin file

Comment 5

[Grace Bush]

adding Samir to cc list

Comment 6

[Samir Gehani]

The ASEncoder shares the same creator type, 'MOZZ', as Mozilla and so launching
the shortcut args' files launches ASEncoder which chokes. This happens only on
machines (like Grace's) that had ASEncoder registered in their desktop db prior
to installing Mozilla.

The real problem sounds like it is a build issue: mismatched URL's in the
config.ini, new files added to the build but not the packages-mac manifest, or
some such. JJ, let me know if I can be of any assistance in tracking this down.

Comment 7

[J.J. Enser]

I'll be looking in details at the second attachment to find out why there are so
many diffs in the 2 deliveries.

Peter, I'm surprised about the dates differences you mentioned. Did you run
Netscape Installer with an existing "Netscape Folder" ? This would most likely do
an "update" of the build, hence the 2 different date stamps.

Samir, you're right about the ASEncoder creator type which gets confused with
Mozilla itself. You should change the one in ASEncoder (to 'ASed' ?) next time
you produce a build. Also, I still have on my machine a series of icons to use
for the installer (to be linked to MIW.mcp)

Comment 8

[pmock]

JJ,
I just tested it with a fresh download of the NSMacInstaller program.  Prior to
running the install, I deleted my registry, my Documents folder, and any
previous seamonkey build on my partition.  The installed files have todays date.
Maybe I did have a Netscape folder, but normally I would have thrown it away.  I
may have missed it. Now when I try to launch seamonkey, it crashes.

Question, will the shipping version of installer do an update or replacement?

Comment 9

[J.J. Enser]

Samir correct me if i'm wrong, but my understanding is that if the selected
target folder (in the installer wizard) already exists, it will replace existing
files in this folder. other files will remain untouched. I think we can call this
an "update".

I've checked the config.ini from today's NS installer, and it seems to contain
the correct urls for each .xpi file.

If the "Netscape" app from NSMacInstaller crashes on launch, but not the one from
netscape5-mac, this is most likely due to a missing file in the build. I'm still
looking at attachment #1 [details] [diff] [review] to figure out what's going on.

Comment 10

[Samir Gehani]

The installer itself will do (and should have done) a replacement. We force an
overwrite of files that already exist but do not delete obsolete files since we
don't know about them. (Updates using XPInstall technology will be recommeneded
and available from Netcenter's SmartUpdate service as always.)

Comment 11

[J.J. Enser]

The file list in packages-mac has been entirely reviewed and completed to match
the content of the ".sea.bin" files (mozilla and commercial).

The same diff process should be performed with forthcoming builds. Note that some
of the differences might still be detected, but are acceptable. (typically files
in dist/viewer that we don't want to ship)

Comment 12

[Grace Bush]

build 1999121308

Comment 13

[Grace Bush]

Attachment: Diffs for installs on 12/13

Comment 14

[Grace Bush]

Attachment: File comparison for Dec14

Comment 15

[Grace Bush]

Attachment: File comparison for Dec15

Comment 16

[Grace Bush]

Attachment: File comparison for Dec16