212088 - Mozilla crashes when I press OK on an address found via "Name or Email contains" [@ nsAbView::GetCellText]

Status: VERIFIED DUPLICATE of bug 213852

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Enno Borgsteede]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030707
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030707

I just tried to add a work phone number to an existing entry in my address book.
When I pressed OK in the dialog window, Mozilla crashed completely, but when I
checked the address again after restart, the new phone number was there.

The crash only occurs if I enter a few characters in the search field on top of
the screen, i.e. the field named "Name or Email containts:", select the address
from the filtered list, and click OK in the dialog. There's no need to enter
anything, just click OK.

When I select an address without filtering first, everything is OK.

Restarting my system didn't help either.



Reproducible: Always

Steps to Reproduce:
1. Open the Address Book window
2. Type a few relevant characters in the "Name or Email contains" field
3. Double click one of the addresses found
4. Click OK

Actual Results:  
Mozilla crashed, invoking both the MS and Talkback handlers, but saved the
change I made to the address.

Expected Results:  
Close the address dialog and save any changed data.

Comment 1

[Enno Borgsteede]

It looks like the crash only occurs when the filtered list is smaller than the
address list pane. When I select something like "com" in the Name or Email
contains line, resulting in a filtered list that's still bigger than the pane,
there is no crash. The number of characters in the filter is no factor by
itself. When I put in 3 characters in the filter that result in a small list,
say 3 lines, the crash occurs whenever I click OK on an address opened from that
list.

Comment 2

[Enno Borgsteede]

I removed this build and went back to the latest 1.4 release version. The crash
does not occur there, so it's new in 1.5a.

Comment 3

[Olivier Cahagne]

can you post Talkback ID for this crash "mozilla/bin/components/talkback.exe" ?

Comment 4

[Enno Borgsteede]

OK, here's 4 talkback ID's. The last one was produced after I reinstalled the
offending build today:
TB21723563Z
TB21723588W
TB21723728Y
TB21740374E
Hope this helps.

Comment 5

[Olivier Cahagne]

Marking NEW to get stack.

Comment 6

[Enno Borgsteede]

When I press Cancel in the address dialog, there is no crash. OK triggers it
every time, even when I don't change anything in the address itself.

Comment 7

[Wolfgang Preuss]

Actually I'm using Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a)
Gecko/20030710 and observe this behavior too since version 20030627. 
I sent my first dump on 2003/07/04.
It's not necessary to search for an address (and by that going indirectly
through the whole address book). When I scroll onto one of the last entries in
my address book (containing 521 entries), edit it and save it, then Mozilla
crashes. When I edit an entry without reaching the end of the list there is no
crash.
Hope this helps ...
  

Comment 8

[Olivier Cahagne]

I crash build 20030703 on Linux but not a debug build, I get these assertions
when clicking OK:

###!!! ASSERTION: row count did not change by the amount suggested, check
caller: 'rowCount == mRowCount', file nsTreeBodyFrame.cpp, line 1714
Break: at file nsTreeBodyFrame.cpp, line 1714
WEBSHELL- = 5
###!!! ASSERTION: row count changed unexpectedly: 'mRowCount == rowCount', file
nsTreeBodyFrame.cpp, line 2185
Break: at file nsTreeBodyFrame.cpp, line 2185

Comment 9

[Olivier Cahagne]

*** Bug 212975 has been marked as a duplicate of this bug. ***

Comment 10

[Olivier Cahagne]

*** Bug 213526 has been marked as a duplicate of this bug. ***

Comment 11

[Olivier Cahagne]

*** Bug 213589 has been marked as a duplicate of this bug. ***

Comment 12

[Olivier Cahagne]

*** Bug 213769 has been marked as a duplicate of this bug. ***

Comment 13

[Olivier Cahagne]

according to
ftp://ftp.mozilla.org/pub/data/crash-data/detailed-crash-analysis-all.html it's
probably crashing in nsAbView::GetCellText (given the count number and comments
from users)
kw: +topcrash

Comment 14

[timeless]

Attachment: guess

Comment 15

[timeless]

.

Comment 16

[[e-mail]]

Comment on attachment 128638 [details] [diff] [review]
guess

I guess this will just cause yet more debug assertions :-)

Comment 17

[[e-mail]]

Attachment: Fix the cause

Editing a card results in deleting the old card and inserting a new one. As the
tree was only told about the insertion, it tried to display an extra card.

Comment 18

[Jan Varga [:janv]]

Comment on attachment 128686 [details] [diff] [review]
Fix the cause

r=varga

Comment 19

[Aleksander Adamowski]

I've experienced those crashes in a "Customers" folder and in card groups, no
filtering involved. Maybe because the "Customers" folder contains only 4 cards
currently, card groups too.

No crashes in my Personal Address Book, which contains 176 cards which is much
more that could fit on screen.

Some talkbacks:

TB22288114W
TB22288098G
TB22288070E

Comment 20

[Hans Schleichert]

I'm using build 2003072104 under WinNT 4.0 SP6a. It happens only (but always)
when I edit a card from "Collected Addresses". Just open a card, don't change
anything, click ok --> crash. Copy the same card to another address book and
everything is fine.
Talkback ID: TB22298645X

Comment 21

[David :Bienvenu]

Comment on attachment 128686 [details] [diff] [review]
Fix the cause

sr=bienvenu - I can check this in, if you don'thave check rights.

Comment 22

[David :Bienvenu]

adding to cc list.

Comment 23

[timeless]

.

Comment 24

[[e-mail]]

Looks like mscott fixed it his own way...

*** This bug has been marked as a duplicate of 213852 ***

Comment 25

[Wolfgang Preuss]

For my environment this bug has been resolved with
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030731
(and I hope all the duplicates too ...). Thanks.

Comment 26

[Enno Borgsteede]

Same here for Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b)
Gecko/20030731

Comment 27

[Vedran Miletic]

v

Comment 28

[Olivier Cahagne]

*** Bug 216938 has been marked as a duplicate of this bug. ***

Comment 29

[Olivier Cahagne]

*** Bug 219275 has been marked as a duplicate of this bug. ***