[dogfood] Sort (Descending) in Thread Pane does not work



MailNews: Message Display
18 years ago
13 years ago


(Reporter: sol, Assigned: Robert John Churchill)


Firefox Tracking Flags

(Not tracked)


(Whiteboard: [PDT+])


(1 attachment)



18 years ago
Sorting in descending order in the thread pane does not work in today's build
(Build ID 1999120815).

Steps to reproduce:
1. Launch Seamonkey
2. Start Mail (Tasks | Mail)
3. Select Inbox for email account (and supply password when prompted)
4. After headers have loaded, sort by date (by pressing on "Date" column
header). Then, try to reverse the sort order (by pressing on the "Date" column
header again) to get descending sort by date.
     Expected result: Message headers sort by date in descending order.
     Actual result: Message headers remain sorted by date in ascending order.


18 years ago
QA Contact: lchiang → fenella

Comment 1

18 years ago
*** Bug 21256 has been marked as a duplicate of this bug. ***


18 years ago
Assignee: phil → putterman

Comment 2

18 years ago
Reassign to putterman, cc rjc


18 years ago
Assignee: putterman → rjc

Comment 3

18 years ago
I'm reassigning to rjc and cc'ing hyatt.  When David added the column chooser it
broke this part of sorting.  BTW, the column chooser is very cool.  I was just
playing around with it.  In order for the sorting code to set the new sort
direction for the column it does this in a loop that iterates over the children
of the tree looking for columns which used to be children of the tree.  Now that
there's a column chooser, the columns are no longer children of the tree but
instead of a treecolgroup.

Comment 4

18 years ago
The sort code should be smart enough to look for the columns either as children
of the tree OR as children of a treecolgroup that is a child of the tree.


18 years ago
Target Milestone: M13

Comment 5

18 years ago
Linux Redhat (1999-12-09-10 M12)
Sort by Date, Sender, Subject, Status and Size in decending order also do not
Have not tested Win_nt and Mac yet.


18 years ago
OS: other → All
Hardware: PC → All

Comment 6

18 years ago
It won't work on any platform or for any thread pane column.


18 years ago
Summary: Sort (Descending) in Thread Pane does not work → [dogfood] Sort (Descending) in Thread Pane does not work

Comment 7

18 years ago
This is a big regression.
A lot of folks read their mail in reverse dated order (cause natural order, and
reverse order or not yet supported).
Anyway, without this, I need to sit through the slow delete process, and then
select a new message (assuming I use forward date sorted, and then struggle to
read my messages backwards).  This makes reading email REALLY tedious for me.
I marked the original bug as dogfood, but when it was dupped, they dropped the
dogfood tag.  Please consider for dogfood.




18 years ago
Whiteboard: [PDT+]

Comment 8

18 years ago
Created attachment 3399 [details] [diff] [review]
Proposed fix: add support for treecolgroup tags

Comment 9

18 years ago
Looks good.

Comment 10

18 years ago
Just for you, Jar.  :^)

Scott (Putterman), can you try the proposed fix that I've attached to this bug
and see if sorting then starts working again for Mail/News?

[I'm working at home today, and don't have SERA access on my Mac, otherwise I'd
test it for Mail/News myself.]

Comment 11

18 years ago
looks good.  I was able to sort the date both ascending and descending.  thanks
for the fix.

Comment 12

18 years ago
chofmann and/or jar, will you approve this for checkin into M12?

Comment 13

18 years ago
ok,  checkin.  are there other places that use the code being
fixed or is it localized?

Comment 14

18 years ago
There are lots of places which use trees and sort on columns, however I suspect
that at the moment only mail/news uses <treecolgroup> tags at the moment, since
Hyatt just added them.

With these changes, I've tested sorting in other areas (bookmarks, searching) and
things work.

I'm about to go grab some dinner, so I'll check in the fix later this evening
when I get back home.


18 years ago
Target Milestone: M13 → M12

Comment 15

18 years ago
moving on to the m12 radar

Comment 16

18 years ago
Fix checked in.
Last Resolved: 18 years ago
Resolution: --- → FIXED


18 years ago

Comment 17

18 years ago
Linux Redhat 6.0 (1999-12-13-08 M12)
Win_nt  (1999-12-13-09 M12)
Mac (1999-12-13-08 M12)
This problem has been fixed.
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.