212455 - Stopping a document can cause DocShell::Stop() to be called repeatedly for the same document

Status: NEW

(Core :: DOM: Navigation, defect)

Description

[rbs]

Spin off from bug 70030 comment 81:

"As for DocumentViewerImpl::Stop, it is being called a few times. ..."

Comment 1

[rbs]

BTW akkana, since this kicks the crawling code, I wonder about doing:
  if (mEnableRendering && (mLoaded || mStopped) && mPresContext) {
    PRUint16 mode;
    mPresContext->GetImageAnimationMode(&mode);
    if (mode != imgIContainer::kDontAnimMode)
      mPresContext->SetImageAnimationMode(imgIContainer::kDontAnimMode);
  }

or just adding an early check in nsPresContext::SetImageAnimationMode() so that
all call sites don't have to repeat the check? What do you think?

Comment 2

[rbs]

Attachment: [debug only] debugging patch to see the multiple Stop()