212459 - Certificate Manager needs a face lift...

Status: RESOLVED FIXED

(MailNews Core :: Security, defect)

Description

[Scott MacGregor]

I've made some changes to the certificate manager for smime for Mozilla
Thunderbird. Instead of forking those files, I'd like to contribute the changes
back into the the security module.

The changes are all cosmetic:

1) Add standard 5 pixel border around the tab panel (we use this padding in many
other tab panel dialogs)

2) make the certManager a dialog instead of a window

3) Add an OK button which can be used to dismiss the dialog

4) Inherit the ok and help button from the dialog overlay instead of trying to
insert the help button manually. This means the buttons will show up with the
correct orientation for the platform being used.

5) Add spacing between the tree control and the Edit / Delete  buttons
underneath the tree.

Screen shots coming up.

Comment 1

[Scott MacGregor]

Attachment: Screen shot of the current dialog on windows

Comment 2

[Scott MacGregor]

Attachment: thunderbird cert manager dialog

Comment 3

[Scott MacGregor]

Attachment: the patch that makes this UI change possible

In addition to what was listed above, this patch makes sure the dialog comes up
centered on the screen and the width is intrinsically determined and is not
fixed.

Comment 4

[Kai Engert (:KaiE:)]

Comment on attachment 127572 [details] [diff] [review]
the patch that makes this UI change possible

r=kaie

I have some concerns and suggestions, but I do not want to stop this change
from happening. Feel free to take from my suggestions what you think makes
sense.

I predict there might again happen something that happened in the past already:
- people will notice the OK dialog and will think, their changes won't be
active until they hit OK (which is a false assumption)
- people will ask for a cancel button, which would give the wrong assumption
the actions in the dialog can be canceled (which they can't)

So hopefully will understand the OK button is simply a close button, and not
ask a for a cancel button.

We have another open bug that requests to add a close button to the cert
manager. So one suggestions is, rename the OK button to say "close".

Another suggestion, we have the similar dialogs "device manager" and "crl
manager". I'd suggest it makes sense to keep those security manager dialogs
consistent and apply the same change to all three windows.

Comment 5

[Scott MacGregor]

Thanks Kai. I made similar changes to the device manager and the crl manager as
part of this checkin.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

 <!DOCTYPE window SYSTEM "chrome://pippki/locale/certManager.dtd">
 
-<window id="certmanager" 
+<dialog id="certmanager" 

could you fix the doctype to match the root element? (change window to dialog)

Comment 7

[Scott MacGregor]

Thanks Christian. I just checked in the doctype change for those files