21249 - Leaking nsIAtoms

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Patrick C. Beard]

Atoms are reference counted. You're calling nsIContent::GetTag() without
calling NS_RELEASE on the result when you're done with it. Here's a patch:

Index: mozilla/layout/xul/base/src/nsScrollbarButtonFrame.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/xul/base/src/nsScrollbarButtonFrame.cpp,v
retrieving revision 1.7
diff -r1.7 nsScrollbarButtonFrame.cpp
194,195c194,195
<        nsIAtom* tag = nsnull;
<        child->GetTag(tag);
---
>        nsCOMPtr<nsIAtom> tag;
>        child->GetTag(*getter_AddRefs(tag));
228,229c228,229
<         nsIAtom* atom;
<         if (child && child->GetTag(atom) == NS_OK && atom == toFind) {
---
>         nsCOMPtr<nsIAtom> atom;
>         if (child && child->GetTag(*getter_AddRefs(atom)) == NS_OK && atom ==
toFind) {

Comment 1

[Eric Vaughan]

This is fixed

Comment 2

[leger]

BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL.  XUL 
component will be deleted.

Comment 3

[Paul MacQuiddy]

please ignore, massive spam giving [e-mail] backlog of XPToolkits
resolved fixed bugs to verify