Closed
Bug 212523
Opened 22 years ago
Closed 22 years ago
Popup Whitelist is not displaying sites from cookperm.txt in listbox
Categories
(Firefox :: Settings UI, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: ts, Assigned: mconnor)
References
Details
Attachments
(1 file)
822 bytes,
patch
|
noririty
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a) Gecko/20030712 Mozilla Firebird/0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a) Gecko/20030712 Mozilla Firebird/0.6
In Mozilla Firebird/0.6 20030712 the whitelist found under Tools -> Options -->
Web features is not working anymore.
One cannot add sites to the whitelist.
This might be a regression from bug 209475
Reproducible: Always
Steps to Reproduce:
1. Go to Tools -> Options --> Web features
2. Click Add Site..
3. Enter URL and click OK
Actual Results:
Nothing happens
Expected Results:
The site should be added to the whitelist
Nothing is dumped to javascript console
The text on the buttons in the add site.. dialog is also wrongly aligned, (not
part of this bug, only an observation)
Comment 1•22 years ago
|
||
In my case, I think the whitelist is working - my problem is only that it is not
displaying anything in the list in Tools->Options->Web Features.
My old sites are still listed in cookperm.txt, and they work. I can even add and
delete them as well, I think, but the results are not that predictable since I
cannot see what is selected, etc.
Comment 2•22 years ago
|
||
Same thing here. It looks like it is working, just the list of sites are not
being listed. The information is being saved in the cookperm.txt file, but just
not showing up on the pop-up list under the "Web Features" window. So when you
want to delete a site from the list, you actually have to goto the cookperm.txt
file and delete it from there.
Comment 3•22 years ago
|
||
I just noticed that if you access the options via:
chrome://communicator/content/pref/pref.xul
the whitelist for the pop-up windows are listed. So it looks like it is limited
to the "Tools" - "Options" location.
Reporter | ||
Updated•22 years ago
|
Severity: major → blocker
Summary: Popup Whitelist not working → Popup Whitelist is not displaying sites from cookperm.txt in listbox
Assignee | ||
Comment 5•22 years ago
|
||
Erik, any chance you have pre 0707 builds vs. 0709 builds so we can see if this
is really a regression from the checkin for 209475?
Assignee | ||
Comment 6•22 years ago
|
||
taking, this is a regression due to the API change.
patch coming up
Assignee: blakeross → mconnor
Assignee | ||
Comment 7•22 years ago
|
||
pretty easy fix, if the original line had used nsIPermissionManager.POPUP_TYPE
instead of "2" I suspect this wouldn't have been missed in the patches
Assignee | ||
Comment 8•22 years ago
|
||
Comment on attachment 128172 [details] [diff] [review]
fixing breakage due to nsIPermissionManager API change
noririty: need r= and checkin, thanks
Attachment #128172 -
Flags: review?(noririty)
Comment on attachment 128172 [details] [diff] [review]
fixing breakage due to nsIPermissionManager API change
That's right!
caused by Bug 209475.
Attachment #128172 -
Flags: review?(noririty) → review+
Comment 10•22 years ago
|
||
checked in, r=me.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 12•22 years ago
|
||
*** Bug 213157 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•