212539 - Customize Toolbar dialog too small to fit contents

Status: RESOLVED WONTFIX

(Toolkit :: Toolbars and Toolbar Customization, defect)

Description

[Boris Zbarsky [:bzbarsky]]

BUILD: Mozilla Firebird 0.6 and Mozila Firebird July 10 Linux nightly.

STEPS TO REPRODUCE:
1)  Start browser with a clean install and clean profile
2)  Open "View" menu
3)  Select Toolbars > Customize

EXPECTED RESULTS: Able to see entire dialog, including button to dismiss the dialog

ACTUAL RESULTS: Dialog is too small; content cut off

POSSIBLY RELEVANT INFORMATION:
1152x864 resolution, 100dpi (with 100dpi fonts default)
No userChrome.css (clean profile)
No GTK themes
No changes made to default browser settings (default font sizes, theme, etc).
XFree86-4.2.0-72 (RedHat 8)
AfterStep 1.8.8 Window manager
sirLurxalot saw this as well; he probably has somewhat different
   resolution/fonts/X/WM

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Full-desktop screenshot of the problem

Comment 2

[Boris Zbarsky [:bzbarsky]]

One more note... in that screenshot it looks like the dialog is just sizing to
the size of the browser window, but that's not the case.  Making the browser
window reasonably-sized does not affect the size of that dialog.

Comment 3

[Boris Zbarsky [:bzbarsky]]

This probably depends on bug 171454, though I'm not using large fonts by any
means (so depending on how bug 171454 is fixed it may or may not fix this bug).

Comment 4

[André Dahlqvist]

Boris, I believe it's a dupe of 171454. My fonts aren't large either.

Comment 5

[Chu Alan "sprite"]

brois, 
my understanding to the problem is that when the row of button/checbox/selectbox
is too long to fit in the window, it will push the content of the dialog beyond
the border. In this sense, the problem arises when the font of a particular
system makes that button/checkbox/selectbox bar too long to fit in the window,
no matter it is default or customize font size or not (of course it is a much
more serious problem when the bug is visible when user is using standard/default
font size, but the underlying problem is still the same :))

Comment 6

[Boris Zbarsky [:bzbarsky]]

Yes, I am quite aware of what is causing the problems, thank you.  Nevertheless,
there are two main ways of fixing bug 171454:

1)  Address the real problem (the fact that the dialog is sized in one set of
    units and its contents in another).
2)  Change the size of the fonts used in the dialog (eg by using style rules).

Depending on which course of action is taken, this bug may or may not get fixed.

In any case, I think further comments on this bug are superfluous till either
bug 171454 is fixed or this bug is marked duplicate of it.

Comment 7

[Simon Paquet [:sipaq]]

Taking QA Contact

Comment 8

[Adam Roben]

Confirming bug still present on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5b)
Gecko/20030804 Mozilla Firebird/0.6.1

Comment 9

[Tracy Walker [:tracy]]

*** Bug 266400 has been marked as a duplicate of this bug. ***

Comment 10

[Boris Zbarsky [:bzbarsky]]

I'm going to go out on a branch here and reassign to someone who may conceivably
care... ;)

Comment 11

[Carlos Alén Silva]

I think this is fixed.

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Carlos Alén Silva from comment #11)
> I think this is fixed.

I just reproduced it on Firefox Nightly v23 on Win7.

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

This was fixed in Firefox by the Australis work. Firefox' Customize Mode is now a full page that has a scrollbar if necessary and the browser can be maximized to take up the full screen size.

There are no plans to update the Customize Toolbar dialog, so it doesn't make sense to keep this bug around.