21268 - Re: Small Frames

Status: VERIFIED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect, P3)

Description

[st8]

Here is an example of framset being strange,  thanks for your time

Comment 1

[st8]

Attachment: Frameset doing unexpected stuff

Comment 2

[karnaze (gone)]

Reassigning to Eric.

Comment 3

[Eric Pollmann]

This ia a carryover of Nav's logic.  We're sizing a cols="0%,100%" frameset
document to the give a width to the left column.

Some code of interest is in nsHTMLFramesetFrame::CalculateRowCol() and
nsHTMLFramesetFrame::GenerateRowCol()

Comment 4

[Eric Pollmann]

See also related bug 20459

Comment 5

[ekrock's old account (dead)]

Ugly but not fatal to user experience. Moving to M16.

Comment 6

[ekrock's old account (dead)]

Bulk moving [testcase] code to new testcase keyword. Sorry for the spam!

Comment 7

[Eric Pollmann]

We were doing the bad compatability math in nsFrameSetFrame::ParseRowColSpec.  
The fix is to change it from:
 if (i<=0) i=1 or i=100/count;
to:
 if (i<0) i=0;

I think it would be safe to fix this even for nav compatability mode, as I doubt 
any web sites depend on the old behaviour. :)  I'll walk the top 100 before 
checking this in though, of course.

Comment 8

[Eric Pollmann]

Fix checked in.  To verify, view the attached test case. You should see
lycos.com, but none of yahoo.com.  Thanks!

Comment 9

[Chris Petersen]

Fixed in the May 30th build.