212695 - Scrolling to named anchors in XHTML files from chrome doesn't work

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[Jessica Blanco]

Clicking on a link in an xhtml page that's suppose to take you to a named anchor
on a different page will bring up that new page, which has the anchor; but will
not scroll to the location referenced. The page is just loaded. I see this using
xhtml files from chrome. 

This problem was fixed in nsHTMLContentSink.cpp in 2001, but never got fixed in
nsXMLContentSink.cpp. I'm attaching a patch that uses that same fix.

Comment 1

[Jessica Blanco]

Attachment: patch with fix

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 127761 [details] [diff] [review]
patch with fix

Ugh.  The problem is that things that don't support nsIURL do NOT support the
concept of anchors, really...  So this is all a pretty gross hack; probably to
get wyciwyg: to work or something like that.  :(

We really need a better way to handle anchor references.

sr=me on making this be just like the html sink, though.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 127761 [details] [diff] [review]
patch with fix

please move the "If the document we are loading..." comment to after the new
code since it doesn't really apply to what you're doing (nor did it before)

Comment 4

[Mike Kaply [:mkaply]]

Fix checked in to trunk. I want this on the branch, but I'm just not sure...