21282 - File | Save Page As: remove "Page" -> "Save As.."

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P3)

Description

[cpratt]

Build ID: 1999120808
Platform: all

To reproduce:
- Launch Mozilla
- Select File | Open File
- Open a local image file (eg /res/arrow.gif)
- Drop down the File menu

Result: Note that what used to be called "Save As" is now "Save page as". I
don't think that this is correct. Why?
- "Save As" is what we used in previous versions of Communicator
- "Save As" is the de facto standard in IE, OE, Office, etc
- "Save page as" doesn't make sense when viewing things other than pages (such
as image files)

I suggest this be changed back to "Save As..." (note the capitalization too).

Comment 1

[Eli Goldberg]

German?

Comment 2

[shuang (gone)]

If it is already speced out,then do whatever the spec says for now. Re -assign
it to german to make final decision in the pec details if it hasn't speced out.

Comment 3

[leger]

Moving all UE/UI bugs to new component: User Interface: Design Feedback
UE/UI component will be deleted.

Comment 4

[jglick]

I checked with German. Use "Save As...".  Please reassign this bug to the 
correct engineer to be implemented.

Comment 5

[jglick]

Please assign to correct engineer to be implemented.

Comment 6

[verah (gone)]

Reassigning to Ben and setting target milestone to M20.

Comment 7

[don]

Move to M21 target milestone.

Comment 8

[Chris McAfee]

*** Bug 39958 has been marked as a duplicate of this bug. ***

Comment 9

[Chris McAfee]

UI, ben.  Easy, one-liner.

Comment 10

[Chris McAfee]

mcafee

Comment 11

[Chris McAfee]

Attachment: patch

Comment 12

[Chris McAfee]

fixed on trunk, rtm branch frozen

Comment 13

[sairuh (rarely reading bugmail)]

the patch was checked in the trunk --why not check it into the branch as well?
nominating for rtm, and reopening to get pdt's attention. if pdt won't approve,
then re-resolve this and add relnoteRTM (sigh).

Comment 14

[sairuh (rarely reading bugmail)]

another question for mcafee. with this change, how is the menu affected when
viewing frames? right now (ie, viewing a page w/frames w/branch bits), there's
now Save Page As... and Save Frame As... in the File menu.

Comment 15

[Chris McAfee]

I don't have a good answer for the frames scenario.
Save As... means "Save everything you see as" as it is
checked in right now.  How do you save a Frame Set?
Maybe we should grey out Save As for the frames case.

Comment 16

[Chris McAfee]

I don't think this is an rtm issue, it's a UI nit.
We shouldn't be checking nits into the branch.

Comment 17

[don]

Minus.  Won't hold RTM for this.

Comment 18

[Chris McAfee]

marking fixed, this is not landing onto the branch.
We should file a new bug for the frames case.

Comment 19

[sairuh (rarely reading bugmail)]

verified in the trunk [2000.10.11.08] on linux. not marking vrfy till it's
finally checked in to the branch (ie, not sure if during the post-rtm fun this
will go into a branch, or just stay in the tip *sigh*.)

also filed bug 56540 for the frames case (unfortunately in that one, the
behavior differs btwn Mac and win32/unix).

Comment 20

[sairuh (rarely reading bugmail)]

vrfy'ing for the trunk. 2000.11.21.08 winnt [and linux], 2000.11.21.13 mac.