Closed Bug 213243 Opened 23 years ago Closed 23 years ago

Compilation error in nsExternalHelperAppService.o

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
VERIFIED INVALID

People

(Reporter: zbraniecki, Assigned: d_king)

Details

Attachments

(2 obsolete files)

I was unable to compile Firebird with today's sources. Compile log ends with: nsExternalHelperAppService.cpp Building deps for d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppS ervice.cpp g++ -mno-cygwin -o nsExternalHelperAppService.o -c -DOSTYPE=\"WINNT5.1\" -DOSARC H=\"WINNT\" -I../../dist/include/xpcom -I../../dist/include/string -I../../dist /include/unicharutil -I../../dist/include/mimetype -I../../dist/include/uriloade r -I../../dist/include/dom -I../../dist/include/necko -I../../dist/include/rdf - I../../dist/include/webshell -I../../dist/include/helperAppDlg -I../../dist/incl ude/plugin -I../../dist/include/pref -I../../dist/include/intl -I../../dist/incl ude/uconv -I../../dist/include/windowwatcher -I../../dist/include/appcomps -I../ ../dist/include/history -I../../dist/include/toolkitcomps -I../../dist/include/e xthandler -I../../dist/include -I../../dist/include/nspr -fno-rtti -fno -exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -pedantic -Wno-long-long -mms-bitfields -pipe - DNDEBUG -DTRIMMED -DX_DISPLAY_MISSING=1 -DHAVE_SNPRINTF=1 -D_WINDOWS=1 -D_WIN3 2=1 -DWIN32=1 -DXP_WIN=1 -DXP_WIN32=1 -DHW_THREADS=1 -DWINVER=0x400 -DSTDC_HEADE RS=1 -DWIN32_LEAN_AND_MEAN=1 -DNO_X11=1 -D_X86_=1 -DD_INO=d_ino -DSTDC_HEADERS=1 -Duid_t=int -Dgid_t=int -DHAVE_DIRENT_H=1 -DHAVE_GETOPT_H=1 -DHAVE_MEMORY_H=1 - DHAVE_UNISTD_H=1 -DHAVE_MALLOC_H=1 -DHAVE_MMINTRIN_H=1 -DHAVE_LIBM=1 -DNO_X11=1 -DMMAP_MISSES_WRITES=1 -DHAVE_STRERROR=1 -DHAVE_SNPRINTF=1 -DHAVE_MEMMOVE=1 -DHA VE_RINT=1 -DVA_COPY=va_copy -DHAVE_VA_COPY=1 -DHAVE_IOS_BINARY=1 -DMOZ_DEFAULT_T OOLKIT=\"windows\" -DMOZ_PHOENIX=1 -DMOZ_XUL_APP=1 -DMOZ_ENABLE_COREXFONTS=1 -DO JI=1 -DIBMBIDI=1 -DMOZ_XPINSTALL=1 -DMOZ_JSLOADER=1 -DMOZ_MATHML=1 -DMOZ_LOGGING =1 -DMOZ_USER_DIR=\"Mozilla\" -DMOZ_XUL=1 -DMOZ_PROFILESHARING=1 -DMOZ_PROFILELO CKING=1 -DMOZ_DLL_SUFFIX=\".dll\" -DJS_THREADSAFE=1 -DNS_PRINT_PREVIEW=1 -DNS_PR INTING=1 -DMOZILLA_VERSION=\"1.5b\" -D_MOZILLA_CONFIG_H_ -DMOZILLA_CLIENT d:/bu ild_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:91:31: nsToolkitCompsCID.h: No such file or directory d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:155:56: warning: multi-character character constant d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:155:63: warning: multi-character character constant d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:157:61: warning: multi-character character constant d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:157:69: warning: multi-character character constant d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:166:57: warning: multi-character character constant d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:166:65: warning: multi-character character constant d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:167:44: warning: multi-character character constant d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:167:52: warning: multi-character character constant d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:168:42: warning: multi-character character constant d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:168:50: warning: multi-character character constant d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:169:69: warning: multi-character character constant d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:169:77: warning: multi-character character constant d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:170:83: warning: multi-character character constant d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:170:91: warning: multi-character character constant d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:171:56: warning: multi-character character constant d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:171:63: warning: multi-character character constant d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:172:59: warning: multi-character character constant d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:172:67: warning: multi-character character constant d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:173:60: warning: multi-character character constant d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:173:68: warning: multi-character character constant d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:174:37: warning: multi-character character constant d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:174:45: warning: multi-character character constant d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp: In member function `virtual nsresult nsExternalHelperAppService::GetTypeFromExtension(const char*, char**)': d:/build_env/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:2195: w arning: comparison between signed and unsigned integer expressions make[4]: *** [nsExternalHelperAppService.o] Bł+d 1 make[4]: Leaving directory `/cygdrive/d/build_env/mozilla/uriloader/exthandler' make[3]: *** [libs] Bł+d 2 make[3]: Leaving directory `/cygdrive/d/build_env/mozilla/uriloader' make[2]: *** [tier_9] Bł+d 2 make[2]: Leaving directory `/cygdrive/d/build_env/mozilla' make[1]: *** [default] Bł+d 2 make[1]: Leaving directory `/cygdrive/d/build_env/mozilla' make: *** [build] Bł+d 2
I'm getting the same problem, however the error is :- c:/mozilla/source/firebird/mozilla/uriloader/exthandler/nsExternalHelperAppServi ce.cpp: In member function `virtual nsresult nsExternalAppHandler::OnStartRequest(nsIRequest*, nsISupports*)': c:/mozilla/source/firebird/mozilla/uriloader/exthandler/nsExternalHelperAppServi ce.cpp:1407: ` NS_GLOBALHISTORY_CONTRACTID' undeclared (first use this function) Increasing severity due to inability to compile.
Severity: normal → major
Taking...
Assignee: bryner → d_king
Attached patch Patch v1.0 (obsolete) — — Splinter Review
Missing line in a IF MOZ_PHOENIX section.
Comment on attachment 128200 [details] [diff] [review] Patch v1.0 Simple patch, low profile, which just makes the PHOENIX and THUNDERBIRD sections the same for the MOZ_XUL_APP setting.
Attachment #128200 - Flags: review?(bryner)
Comment on attachment 128200 [details] [diff] [review] Patch v1.0 Hmmm, scrap that, I missed something....this is only part of the patch.
Attachment #128200 - Flags: review?(bryner)
Attached patch v1.1 (more complete patch) (obsolete) — — Splinter Review
Includes two files missed from the previous patch.
Attachment #128200 - Attachment is obsolete: true
Attachment #128226 - Flags: review?(bryner)
Um... dbaron just removed code like that from this file. I assume you read that bug and such?
that patch is wrong. NS_GLOBALHISTORY_CONTRACTID should now be defined in nsIGlobalHistory.idl, even in phoenix; due to a patch by dbaron.
What steps did you use to do the compilation?
Hmmmm, thanks bz for pointing out what I'd missed. (Must remember, sleep first, check code afterwards). Yes, it is defined in nsIGlobalHistory.idl, but my Phoenix build wasn't picking that up, although my Thunderbird build and my "main" Mozilla build worked fine. All I changed for Phoenix/Firebird was to add :- export MOZ_PHOENIX=1 mk_add_options --MOZ_PHOENIX=1 to my .mozconfig. From reading Bug #212509 it looks like I'm hitting my head against a bug that is partially fixed. I say partially as nsToolkitCompsCID.h still has the def for NS_GLOBALHISTORY_CONTRACTID which should have been removed by dbaron's patch. I can't check lxr.mozilla.org as it doesn't seem to have the mozilla/toolkit directory available for viewing.
Hmmm, the "--" was force of habit from all the ac_add_options. I'll remove that, and my patches to see what happens... As for "toolkit". When I follow the link to LXR from http://www.mozilla.org, I get eventually to http://lxr.mozilla.org/seamonkey/source/ So, what's the differance between http://lxr.mozilla.org/seamonkey/ and http://lxr.mozilla.org/mozilla/, or more accurately, which one should I be using? Which one does cvs-mirror use? I've filed a new bug on LXR missing "toolkit". See Bug #213485 if interested.
http://lxr.mozilla.org/ has links to the various subparts of LXR with clear descriptions of how they differ.
Removing the "--" has made a difference. Although, I'm sure it used to work before....oh well, I'd better keep a closer eye on the Firebird bugs/changes. I had to clobber my build as it was partial with the "--", and partial without, and was getting a bit confused. Either that or WinXP was telling me to get some sleep ;-) I'm repulling now for the latest changes, and then a full build starts. More info later today (NZST).
OK, fixing my .mozconfig, clearing and repulling my Firebird tree fixed the problem. I'm using the just completed build to post this. Marking INVALID, and will clean up patch info.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → INVALID
Comment on attachment 128226 [details] [diff] [review] v1.1 (more complete patch) Patch invalid.
Attachment #128226 - Attachment is obsolete: true
Attachment #128226 - Flags: review?(bryner)
verified
Status: RESOLVED → VERIFIED
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: