Closed Bug 21378 Opened 25 years ago Closed 25 years ago

[dogfood] CanUndo and CanRedo report opposite of what they should

Categories

(Core :: DOM: Editor, defect, P3)

Product:
Core
Component:
DOM: Editor
Platform:
x86
Windows NT
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: buster, Assigned: buster)

References

Details

(Whiteboard: [PDT-] waiting till 21376 is fixed before verifying) 

with text controls being hooked up to menus, it's important to enable/disable
commands appropriately.  I'm nominating this bug as dogfood simply because the
fix is so trivial, just reversing the boolean that's returned, turning an ==
into a != in two places.  No other code relies on these changes except code that
tells the UI whether these commands are enabled or disabled.

Let me know if I can check it in.  Already reviewed.
Whiteboard: fix in hand, trivial
Target Milestone: M12
Whiteboard: fix in hand, trivial → approved by chofmann
this was approved by chofmann this morning. Steve, go ahead and check it in.
Whiteboard: approved by chofmann → [PDT-]approved by chofmann
Ok to check in, but utting on the PDT- radar.
Status: NEW → RESOLVED
Closed: 25 years ago
Depends on: 21376
Resolution: --- → FIXED
fixed.  You can verify this by seeing if undo and redo are enable and disabled
appropriately in the address book chrome, browser url bar, html text areas in
the content, etc.  However, you won't easily see this until bug 21376 is fixed.
waiting till 21376 is fixed before verifying
Whiteboard: [PDT-]approved by chofmann → [PDT-] waiting till 21376 is fixed before verifying
Status: RESOLVED → VERIFIED
verified in 12/20 build. will re-verify when 21376 is fixed...
You need to log in before you can comment on or make changes to this bug.