213782 - not asking for password even if "needs password" in server options is enabled

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Martin Leonhartsberger]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; de-AT; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; de-AT; rv:1.4) Gecko/20030624

I have a clean 1.4 install, and tried various versions of the 0.9 series (this
problem didn't occur while i was using 0.8). currently im using 0.9.12.
When i open chatzilla, the connection to the only server in my serverlist is
made, and psybnc askes me for my password, which i have to enter via /quote pass
<password>
In 0.8.34, i got asked for my password, but in 0.9, i don't get asked. It's
enabled in the server options, and when i view the initialURLs string, it's
"irc%3A//Sol%3A15678/%2Cneedpass" without the quotation marks.
(i assume that means "irc://Sol:15678, needpass" or something similiar)

From this I assume that the "needpass" preference is indeed correctly safed, but
not correct read out/processed.
Maybe psybnc is the problem? I'm using the latest version of this as well
(again, no problem with 0.8.34)

Reproducible: Always

Steps to Reproduce:
1.Open chatzilla



Actual Results:  
I now have to input the password manually via /quote pass <pw>.

Expected Results:  
It should have done this automatically.

Comment 1

[Robert Ginda]

*** Bug 213785 has been marked as a duplicate of this bug. ***

Comment 2

[James Ross]

Ok, this is an easy one. See:
http://lxr.mozilla.org/mozilla/source/extensions/irc/xul/content/static.js#1487

Should also check url.pass is not null, i.e. something like:
        if (("pass" in url) && url.pass)

I'm guessing the needkey code here:
http://lxr.mozilla.org/mozilla/source/extensions/irc/xul/content/static.js#1564
will also need fixing, but I haven't checked.

In fact, there's a few others, charset for one, I've just spotted. The basic
problem is that parseIRCURL is setting all these properties to null before
parsing, and gotoIRCURL is simply checking for their existence (using 'in'), not
if they are non-null.

I can probably provide a full CVS diff if needed.

Comment 3

[Tony Gorman]

Confirmed on Windows XP Pro, Windows 2000 Pro and windows 2000 Server

Last build that works on either Mozilla or FireBird is 0.8.34

Comment 4

[Robert Ginda]

fixed in 0.9.40