213880 - Koren font KSC5601.1987-1 support

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Kishan Thomas]

Mozilla currently supports only two "KSC5601.1987-0" encoded fonts
(daewoo-mincho-ksc5601.1987-0 and daewoo-gothic-ksc5601.1987-0)

On HP-UX the Korean fonts are available as "KSC5601.1987-1" encoding.
How can we enable Mozilla to support KSC5601.1987-1 encoded fonts for
Korean locales.

Comment 1

[Jungshik Shin]

Phew... I'd rather recode those BDFs  to ksc5601.1987-0....

Can you tell me exactly what ksc5601.1987-1 (charset-registry) is on HP/UX?
(a sample BDF - gzipped or bzipped - would be nice to have)

If ksc5601.1987-1 fonts on HP/UX are just KS C 5601-1987 invoked on
the GR side, it's easy but it may increase the code size (unless a major
rewritting of ucvko a la ucvcn is done)

Does HP/UX also have GB2312.1980-1 , JISX0208.19xx-1 and JISX0212.19xx-1 
as well? If that's the case, it might be better to solve it in Gfx:Gtk/Xlib..

  

Comment 2

[Kishan Thomas]

>Can you tell me exactly what ksc5601.1987-1 (charset-registry) is on HP/UX?
>(a sample BDF - gzipped or bzipped - would be nice to have)

The files are in .pcf format, I will check if we can provide a sample pcf file. 
xlsfonts shows these types of fonts in ksc5601.1987-1 

-hp-sammul-medium-r-normal--64-640-75-75-c-640-ksc5601.1987-1
-hp-pilgi-medium-r-normal--64-640-75-75-c-640-ksc5601.1987-1
-hp-dotum-medium-r-normal--64-640-75-75-c-640-ksc5601.1987-1
-hp-batang-medium-r-normal--64-640-75-75-c-640-ksc5601.1987-1
-dt-interface user-medium-r-normal-xxs-16-160-75-75-m-160-ksc5601.1987-1
-dt-interface system-medium-r-normal-xxs-16-160-75-75-p-160-ksc5601.1987-1

>If ksc5601.1987-1 fonts on HP/UX are just KS C 5601-1987 invoked on
>the GR side, it's easy but it may increase the code size (unless a major
>rewritting of ucvko a la ucvcn is done)

Looking at the above xlsfonts listing is it going to be easy or lot of work to
support ?

>Does HP/UX also have GB2312.1980-1 , JISX0208.19xx-1 and JISX0212.19xx-1 

HP-UX has gb2312.1980-1 but not jizx0208.19xx-1 and JISX0212.19xx-1,
Instead HP-UX has jisx0208.19xx-0 and jisx0212.19xx-0

>as well? If that's the case, it might be better to solve it in Gfx:Gtk/Xlib..

What does that mean ?  since I am not very familiar with Mozilla i18n 

Comment 3

[Jungshik Shin]

PCF can be easily converted back to BDF. Anyway, can you send me or upload one
of PCFs in ksc5601.1987-1 and gb2312.1980-1. I want to make sure that they're
indeed what I think they're.   

> Looking at the above xlsfonts listing is it going to be easy or lot of work to
> support ?

  The list of fonts doesn't give much information. ksc5601.1987-1 should be KS C
5601 invoked on the GR (0xA1 - 0xFE) side if HP/UX followed the usual XLFD
charset-registry naming scheme. The same should be true of gb2312.1980-1.

Anyway, it's easy to add support for both. My comments about the code size and
doing it in Gfx:Gtk  can be ignored. The increase would be ~100 bytes.  

I'll upload a patch later.

Comment 4

[Jungshik Shin]

Attachment: a patch

After making a patch to add an encoder for KS C 5601 GR font half an hour ago,
I took another look at nsFontMetricsGTK.cpp because it's very unlikely that the
lack of support for gb2312.1980-1 on HP/UX have been unnoticed given that HP/UX
doesn't have a gb2312.1980-0 font at all. Moreover, it bothered me that I had
to add a converter for KSC5601 GR which is only trivially different from GL.
Voila ! GFX:Gtk  and GFX:Xlib are written to make use of GL encoders for  both
GL and GR fonts.

So I wrote this patch that is even simpler than the original patch (not
uploaded).

Comment 5

[Jungshik Shin]

Comment on attachment 128918 [details] [diff] [review]
a patch

The patch is basically a 2-liner making Mozilla treat ksc5601.1987-1 (GR
encoded) fonts the way it treats gb2312.1980-1 (GR encoded) fonts.

Comment 6

[Simon Montagu :smontagu]

Comment on attachment 128918 [details] [diff] [review]
a patch

r=smontagu

Comment 7

[Jungshik Shin]

Comment on attachment 128918 [details] [diff] [review]
a patch

fix checked into the trunk. 

asking for a1.4. It's a trivial two-line fix, but apparently important to
Korean HP/UX users with KS C 5601(KS X 1001) GR fonts. The risk is zill to
others.

Comment 8

[Mi-Young Lee]

Jungshik, I appreciate your efforts very much.
With the fix, I can set Korean bitmap and TrueType fonts on HP-UX.

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 128918 [details] [diff] [review]
a patch

a=asa (on behalf of drivers) for checkin to the 1.4 branch.

Comment 10

[Jungshik Shin]

Thanks for a. Fix was just checked into 1.4 branch. 
Mi-Young, can you mark this bug as verified (I'm marking it as resolved/fixed
now) because you already verified it on HP/UX? TIA

Comment 11

[Kishan Thomas]

Thank You Jungshik !

Comment 12

[Mi-Young Lee]

I don't have the authority to mark the bug as verified.
Probably, the bug owner, Kishan can mark it as verified.
Kishan, please do it.

Comment 13

[Kishan Thomas]

Verified the fix on HP-UX 

Comment 14

[Jungshik Shin]

Thansk for marking as verified. The fix was also checked into the 1.4.x branch.