21414 - Conversion from XIF to kTextMime is restricted to ISO-8859-1

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[nhottanscp]

This is separated from 8427. This bug is about paste to other application (and
when kUnicodeMime is not available). I thought it would be simpler to create a
specific bug than adding comments to 8427 which has more issues involved.

As stated in 8427, ToNewCString is used when converting from XIF to kTextMime.
We have data loss in case of characters which are not in the range of
ISO-8859-1. We need to convert from unicode to the platform charset (ACP).
Possible fix is to use the stream version of content sink which takes charset.
Or hook up the unicode converter instead of calling ToNewCString (which I will
post the diff later).

Comment 1

[nhottanscp]

Attachment: possible fix (using unicode converter), review needed

Comment 2

[nhottanscp]

Mike, Akkana, could you review the diff?

Comment 3

[Mike Pinkerton (not reading bugmail)]

taking this bug, as i have fixes in my tree.

Comment 4

[Mike Pinkerton (not reading bugmail)]

variation on nhotta's patch checked in.

Comment 5

[Mike Pinkerton (not reading bugmail)]

reopening per discussion with nhotta. my application of his proposed patch was
flawed and I want to continue investigating the use of the stream api's.

Comment 6

[Mike Pinkerton (not reading bugmail)]

accepting

Comment 7

[Mike Pinkerton (not reading bugmail)]

ok, take two. i think i did it right this time ;)

Comment 8

[nhottanscp]

I tested this with Japanese and I was able to paste Japanese from mozilla to
simple text.
I used OS-9 with Japanese option installed. Since it's not localized to
Japanese, platform charset was MacRoman. So I had to change the source to hard
code the platform charset to Shift_JIS.
So for the verification, this needs to be tested on localized systems (e.g.,
Win98-J, MacOS9-J).

BTW, the other direction (copy from simple text to mozilla) doesn't seemed to be
working for non Latin1 (e.g. didn't work for MacRoman).

Comment 9

[Mike Pinkerton (not reading bugmail)]

correct, since our charset conversion is done when we convert XIF to kTextMime.
Open a different bug, I guess.

Comment 10

[Teruko Kobayashi]

Changed QA contact to [e-mail].

Comment 11

[nhottanscp]

Here is how to verify.
Win95/Win98 - Use Japanese localized system, copy Japanese text from mozilla and 
paste to notepad
Macintosh - Use Japanese localized system, copy Japanse text from mozilla and 
paste to simpletext
Unix - ask Xianlang

Comment 12

[Teruko Kobayashi]

I verified this in 2000020108 Win32 under Winnt 4.0J and Win95J.  

Comment 13

[Teruko Kobayashi]

I verified this in 2000020408 Mac build.  I think Linux does not work, but we need more time to investigate this in Linux.
I mark this as verified.  After we find out the problem in Linux, we will open new bug.