214249 - nsIFormSubmitObserver should not use nsIContent

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

I was fixing up all this usage of nsIContent in code that has no business using
it (camino, toolkit, etc), and one culprit that stuck out was nsIFormSubmitObserver.

Imo we should make that a proper IDL interface, rename to nsIFormObserver (per
jst's suggestion), and pass in an nsIDOMNode, not an nsIContent.

Comment 1

[Christian Persch (GNOME) (away; not receiving bug mail)]

Also it's inconvenient that it uses nsIDOMWindowInternal instead of the public, frozen nsIDOMWindow[2].
As to nsIContent, maybe it should use nsINode instead.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Yeah, using nsIDOMWindow would be good.  As for nsINode, it's the same as nsIContent for purposes of this code; I still think than nsIDOMNode is the way to go.

Comment 3

[Christian Persch (GNOME) (away; not receiving bug mail)]

Right. I was under the mistaken illusion that nsINode was available to non-MOZILLA_INTERNAL_API code, which it is not.

Comment 4

[Boris Zbarsky [:bzbarsky]]

It might become that way, actually (due to such code using nsIDocument), but that define is just a linkage issue, not whether you _should_ be using the interface.  You shouldn't be.