nsAddressBook.h:81: warning: `struct ExportAttributesTableStruct EXPORT_ATTRIBUTES_TABLE[53]' defined but not used

RESOLVED FIXED

Status

SeaMonkey
MailNews: Address Book & Contacts
--
enhancement
RESOLVED FIXED
14 years ago
13 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

14 years ago
boot/home/dbg-i586-pc-beos/dist/include/addrbook/nsAddressBook.h:81: warning:
`struct ExportAttributesTableStruct EXPORT_ATTRIBUTES_TABLE[53]' defined but not
used
(Assignee)

Comment 1

14 years ago
Created attachment 128828 [details] [diff] [review]
share with nsAddrDatabase.cpp
(Assignee)

Updated

14 years ago
Attachment #128828 - Flags: superreview?(bienvenu)
Attachment #128828 - Flags: review?(bienvenu)
(Assignee)

Updated

14 years ago
Attachment #128828 - Flags: superreview?(bienvenu)
Attachment #128828 - Flags: superreview?(alecf)
Attachment #128828 - Flags: review?(bienvenu)
Attachment #128828 - Flags: review?(alecf)

Comment 2

14 years ago
Comment on attachment 128828 [details] [diff] [review]
share with nsAddrDatabase.cpp

woah, this is a hacky way to define this.

lets do this the right way - move the header into a C++ file, and predeclare it
in a header.
Attachment #128828 - Flags: superreview?(alecf)
Attachment #128828 - Flags: superreview-
Attachment #128828 - Flags: review?(alecf)
Attachment #128828 - Flags: review-
(Assignee)

Comment 3

14 years ago
Created attachment 135164 [details] [diff] [review]
'the wrong way'
Attachment #128828 - Attachment is obsolete: true
(Assignee)

Comment 4

14 years ago
Created attachment 135165 [details] [diff] [review]
use extern
Attachment #135164 - Attachment is obsolete: true
(Assignee)

Updated

14 years ago
Attachment #135164 - Attachment description: 'the right way' → 'the wrong way'
(Assignee)

Updated

14 years ago
Attachment #135165 - Flags: superreview?(alecf)
Attachment #135165 - Flags: review?(alecf)

Comment 5

14 years ago
Comment on attachment 135165 [details] [diff] [review]
use extern

should this be 'const'?

r/sr=alecf, hopefully with a const.
Attachment #135165 - Flags: superreview?(alecf)
Attachment #135165 - Flags: superreview+
Attachment #135165 - Flags: review?(alecf)
Attachment #135165 - Flags: review+
(Assignee)

Comment 6

14 years ago
checked in
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.