Closed
Bug 214387
Opened 21 years ago
Closed 21 years ago
nsAddressBook.h:81: warning: `struct ExportAttributesTableStruct EXPORT_ATTRIBUTES_TABLE[53]' defined but not used
Categories
(SeaMonkey :: MailNews: Address Book & Contacts, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 file, 2 obsolete files)
|
7.65 KB,
patch
|
alecf
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
boot/home/dbg-i586-pc-beos/dist/include/addrbook/nsAddressBook.h:81: warning: `struct ExportAttributesTableStruct EXPORT_ATTRIBUTES_TABLE[53]' defined but not used
Attachment #128828 -
Flags: superreview?(bienvenu)
Attachment #128828 -
Flags: review?(bienvenu)
Attachment #128828 -
Flags: superreview?(bienvenu)
Attachment #128828 -
Flags: superreview?(alecf)
Attachment #128828 -
Flags: review?(bienvenu)
Attachment #128828 -
Flags: review?(alecf)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 128828 [details] [diff] [review] share with nsAddrDatabase.cpp woah, this is a hacky way to define this. lets do this the right way - move the header into a C++ file, and predeclare it in a header.
Attachment #128828 -
Flags: superreview?(alecf)
Attachment #128828 -
Flags: superreview-
Attachment #128828 -
Flags: review?(alecf)
Attachment #128828 -
Flags: review-
Attachment #128828 -
Attachment is obsolete: true
Attachment #135164 -
Attachment is obsolete: true
Attachment #135164 -
Attachment description: 'the right way' → 'the wrong way'
Attachment #135165 -
Flags: superreview?(alecf)
Attachment #135165 -
Flags: review?(alecf)
|
|
||
Comment 5•21 years ago
|
||
Comment on attachment 135165 [details] [diff] [review] use extern should this be 'const'? r/sr=alecf, hopefully with a const.
Attachment #135165 -
Flags: superreview?(alecf)
Attachment #135165 -
Flags: superreview+
Attachment #135165 -
Flags: review?(alecf)
Attachment #135165 -
Flags: review+
checked in
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•