Closed Bug 214465 Opened 21 years ago Closed 21 years ago

Default theme fails themeVersion check

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firebird0.7

People

(Reporter: usedtobeahero, Assigned: bugs)

References

Details

(Keywords: regression) 

User-Agent:       Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1

I cannot revert to the default theme using the themes section in the Options
window. After installing additional themes I can change between themes I
installed myself but I just cannot revert to the Mozilla Firebird theme. Nothing
happens when I click OK and the only way to get back to the default theme is to
uninstall the present theme which results in the browser reverting to the
default theme.

Reproducible: Always

Steps to Reproduce:
1. Change theme to a user-installed one.
2. Try and change back to the default theme; nothing happens on clicking OK
after selecting the Mozilla Firebird theme.
3.
This WFM on Win2k, is it that the dialog doesn't close or that the setting
doesn't apply?  Does this occur with a clean profile and installed into a clean
directory?
QA Contact: asa → mconnor
The options window doesn't close on clicking OK and the setting doesn't apply
either. I installed this version in a fresh directory, and I just checked with
an absolutely new profile; no difference, it still doesn't work.
Where did you get this distribution?  Is this an official 0.6.1 build or a
package from a vendor or other package?
Ok, got a bit of information on this I think.

Confirming bug.

Firstly, the dialog does not close because of a JavaScript exception here:
http://lxr.mozilla.org/mozilla/source/browser/components/prefwindow/content/pref-themes.js#136

But, this line is for the "This skin isn't supported" message! It seems, rather
oddly, that the Modern skin is "ok" and the Mozilla Firebird skin is not.

(can be tested on a build using the following in the JS console:
Components.classes["@mozilla.org/chrome/chrome-registry;1"].getService(Components.interfaces.nsIXULChromeRegistry).checkThemeVersion("modern/1.0")
Components.classes["@mozilla.org/chrome/chrome-registry;1"].getService(Components.interfaces.nsIXULChromeRegistry).checkThemeVersion("classic/1.0")
which return true and false respecively.)
Status: UNCONFIRMED → NEW
Ever confirmed: true
It's an official mozilla.org build.
Ok, you can forget the 2nd part of my comment - the problems just vanished. :)
I have to shut down the browser to switch back and forth between Pinball and the
default theme. I ought to test this with another theme (oh, the horror...)
I can confirm the same behaviour David reported in today's nightly.  Mozilla/5.0
(Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030805 Mozilla
Firebird/0.6.1+  Now I'm stuck using Pinball until I restart my browser, what
kind of person makes a theme like this?  Er... wait... :)

There's a related bug for what James mentioned with the JS errors, but that
doesn't affect this bug, I wrote the fix for the exceptions, and this is unrelated.
OS: Linux → All
Hardware: PC → All
i forgot where i read this, but it seems to be true.  as long as you make sure
to uncheck "apply this theme" every time you install a theme, this bug doesn't
show its ugly face.
*** Bug 216440 has been marked as a duplicate of this bug. ***
I can reproduce this. Since around 08/25, the default theme is "designed for an
earlier version/incompatible" again. Bug 217300 also covers this problem. In the
08/31 build there is no way to go back to the default theme. Restarting doesn't
help. Bug 215707 is about the OK button being disabled.

This should be fixed along with bug 217300. But to prevent this in the future,
we should specify the default theme to be always compatible.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030831
Firebird/0.6.1+
Severity: normal → major
Keywords: regression
I don't think we can ship 0.7 with this, as this will be encountered frequently
by users trying out new themes.  Also blocking 213994, as the proposed fix only
shows valid themes, and if the default theme doesn't return valid, its not in
the list.
Blocks: 213994
Target Milestone: --- → Firebird0.7
2 points here:

1.  I wanted to make sure you were aware this is NOT just a theme reversion
problem.  It occurs on a fresh build with new profile with no themes or
extension installed ever.  Tools -> Options -> Themes diplays a message abou
tthe defualt theme being incmpatable even in that case.

2.  I reverted back to the 8/24 nightly which did not have this problem when I
was running it before, but it STILL showed the default theme as being
incompatible.  What had happened was that in the intervening time I had
installed the Firebird Help Viewer which had added a skinversion=1.5 to
chrome.rdf in my profile.

So I would recommend starting with a fresh build, fresh profile, no extensions,
no themes and try to fix just the incompatability message, as the best way to
approach this problem and avoid other mitigating factors.
This didn't regress on the 25th, it was reported after the skinVersion change. 
I think it just became more obvious once the error message went in.
noririty: Are you sure? I'm getting this behavior on the 20030811 build.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030811 Mozilla
Firebird/0.6.1+
*** Bug 217846 has been marked as a duplicate of this bug. ***
*** Bug 218306 has been marked as a duplicate of this bug. ***
I am still getting this on the 2003-09-07 Firebird build for Linux.  One thing
that may or may not help find the problem is that if I comment out all
references to mozapps in the chrome.rdf file the theme seems to be "compatible"
again and all is well.
I have to ask.  Where does the default theme for Firebird come from? (Searching
for "skinversion" via http://lxr.mozilla.org/mozilla/search?string=skinversion
shows no obvious candidates.)

Is the skinversion change actually responsible?  As in, has someone tracked down
a real regression window?
What this bug IS:

When selecting the default theme it does not revert to the default immediately;
one has to open a new Window or restart the browser to get back to the default
theme. This has existed since late July 2003.

What this bug IS NOT:

Since ~20030825 there has been an issue where selecting the default theme gives
an incompatibility message. It's related to the mozapps migration in some
fashion. It's not related to the fb0.7 skinVersion change and subsequent back
out since that change occurred on the 26th or 27th of August, not on the 25th.
Trust me; I was playing around with Pinball at that time and picked up on this
incompatibility issue before a skinVersion change was ever checked in. This
issue is covered by bug 217846.


These are two different issues.
Summary: Cannot revert to the default theme (Mozilla Firebird) from the themes section in the options window. → Reverting to default theme (Mozilla Firebird) does not take effect immediately
"Live" theme switching is also broken, but this bug as originally filed is
related to the theme incompatibility issue, since all other themes could be
selected, although this indicates a different issue from the skinVersion change.

David, please file a distinct bug that explains what breaks on live theme
switching, this bug is NOT about that.  Thanks.

bz: I'm thinking its mozapps based on info from noririty on IRC, more later, I
need to take a couple hours and properly narrow down the regression window.  The
classic/1.0 theme in (I think) m/browser/skin is where the Mozilla Firebird
theme lives.
Summary: Reverting to default theme (Mozilla Firebird) does not take effect immediately → Default theme fails themeVersion check
*** Bug 217846 has been marked as a duplicate of this bug. ***
I give up. Mike, this bug was filed long before the incompatibility issue even
surfaced, so how can it be that? Think about it - this bug was filed on
2003-07-30 yet the mozapps migration which I know caused this incompatibility
issue only appeared on 2003-08-26.
David, this bug is the same symptoms as the themeversion problems, which we have
replication prior to 08/25 for (I would see it intermittently myself, it seemed
to be linked to the "install this theme" which has plenty of problems itself). 
The ability to switch to all other themes except Mozilla Firebird bears that
out.  The mozapps migration seems to have made this consistent, but the problem
has been kicking around for longer than that.

See bug 216440 (duped against this bug already) which is explicitly stating the
incompatibility message occurs on 08-16 builds and comment 17 in this bug which
indicates it can be seen on 08/11.
I can switch from Pinball to Mozilla Firebird in my CVS build after this checkin:
"Missing Firebird skinversion. Thank you Mr.FLS to point this out. b=214465"

But switching in either direction still requires me to open a new window.
Jesse, that's the "live" theme switching which is broken, not really the same
issue.  That's one I would like to have a real regression window for.
Well, once I edit this fix into my chrome.rdf file, with both Pheonity Lite and
Little Firebird I can do live theme swtiching back and forth between either of
them and between them and the default theme.  I suspect the fact that live theme
switching with the Pinball theme does not work is a Pinball theme issue and NOT
a Firebird issue.
After installing the "fix" to chrome.rdf for this problem, the problem will come
back if you install FirebirdHelp version 0.3 beta due to a similar missing
skinVersion.  Is the real fix for this to make the absense of a skinVersion be
treated as the current skinVersion so that not specifying a skinVersion will
always make it appear compatable.
No, that's not the answer, since it ends up causing more problems.  Please file
a bug against firebird help on mozdev noting that, it should get fixed for the
next revision.
With a *new* profile and using a CVS build compiled overnight, there is no theme
switching problem with Pinball or any other theme. There is a slight exception
to this however; the first theme you install will not switch until you open a
new browser window. It doesn't matter which theme. Once you've done that, all
subsequent switches take immediately, though the "Use this theme" checkbox on
the theme install pop-up still doesn't do anything. If you have an old profile,
you may have all sorts of different problems with different themes.

It seems that skinVersion and locale changes necessitate a change of user
profile as well.
Noririty's checkin mentioned in comment 27 fixed this. The default theme is not
"incompatible" anymore. I can swith to another theme and back to the default
one. It switches immediately; I don't have to open another window.
I can confirm some problems mentioned in comment 33, but that's another bug.
Using a new profile helps indeed.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030909
Firebird/0.6.1+
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
verified fixed 2003-11-09
Status: RESOLVED → VERIFIED
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → preferences
You need to log in before you can comment on or make changes to this bug.