214546 - clicking on fewer in filter rules should remove unused lines before it removes the bottom line

Status: RESOLVED WONTFIX

(MailNews Core :: Filters, enhancement)

Description

[Seth Master]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030727
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030727

If you go to message filters, choose a filter, and then edit a filter, if you
have 3 filter rules in place, and then you take the middle filter rule and
remove what is in the criteria to match field, then click on fewer, the bottom,
but still in use filter rule is then removed, instead of the middle filter rule
that is empty.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.



Expected Results:  
I dont see why we should be removing the bottom rule, when the middle rule in
the example above is basically an unused filter rule since the criteria to match
on field is empty. I think the best thing to do is remove the unused rule when
the fewer box is activated instead of removing a filter rule that is in use.

Comment 1

[Mike Cowperthwaite]

Excellent idea.

Comment 2

[Oliver Kluge]

Another idea: Why not remove the filter rule that is currently highlighted and then rename those two buttons to "Add" and "Remove"?

Comment 3

[Mike Cowperthwaite]

Actually, this bug is moot: as of several months ago, the top-level More/Fewer buttons have been replaced by per-rule add/del ([+] & [-]) buttons.