Last Comment Bug 214623 - iframe overlaps text until i force a reflow
: iframe overlaps text until i force a reflow
Status: RESOLVED FIXED
: regression, testcase
Product: Core
Classification: Components
Component: Layout: Block and Inline (show other bugs)
: Trunk
: x86 All
: -- major (vote)
: ---
Assigned To: David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
: Hixie (not reading bugmail)
Mentors:
Depends on: 214077
Blocks:
  Show dependency treegraph
 
Reported: 2003-07-31 07:30 PDT by Jesse Ruderman
Modified: 2003-08-06 17:06 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
testcase (106 bytes, text/html)
2003-07-31 07:32 PDT, Jesse Ruderman
no flags Details
patch (2.99 KB, patch)
2003-08-05 22:21 PDT, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
roc: review+
roc: superreview+
asa: approval1.5b+
Details | Diff | Review

Description Jesse Ruderman 2003-07-31 07:30:58 PDT
When I use the "view style sheets" bookmarklet on a page with a linked style
sheet, the iframe overlaps other text the bookmarklet spits out.  If I force a
reflow (resize window, use Firebird's autoscroll, etc), the iframe jumps to
where it should be.

The testcase doesn't use JavaScript. It's just a simple HTML page with an
iframe.  The testcase is fragile, like bug 214607's: adding space before <html>
or before <body> fixes it.
Comment 1 Jesse Ruderman 2003-07-31 07:32:08 PDT
Created attachment 128949 [details]
testcase

<html><body> <h3>Style sheets</h3> <iframe
src="http://www.squarefree.com/squarefree.css"></iframe></body>
Comment 2 Boris Zbarsky [:bz] (Out June 25-July 6) 2003-07-31 09:23:18 PDT
.
Comment 3 Mats Palmgren (:mats) 2003-07-31 10:19:55 PDT
Bug occurs in 2003-07-28-10 trunk Linux, but works fine in Mozilla 1.4 Linux
Comment 4 Mats Palmgren (:mats) 2003-07-31 11:05:01 PDT
2003-07-22-05: bug does not occur
2003-07-23-05: the IFRAME is not visible at all
2003-07-24-05: the IFRAME and the text overlaps

bug 79315 seems to fit the problem and is in the time frame
Comment 5 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2003-07-31 14:59:07 PDT
Maybe the same as bug 214077...
Comment 6 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2003-08-05 21:20:08 PDT
Actually, this is a widget positioning problem, and I can see two potential
causes of such problems:
 1. we're positioning the views inside-out rather than outside-in in
RelativePositionFrames
 2. we don't call PositionChildViews to reposition any views in descendants of
leaves -- if they have widgets those widgets won't be repositioned.

I think it's the first case that's the problem here.
Comment 7 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2003-08-05 22:21:54 PDT
Created attachment 129262 [details] [diff] [review]
patch
Comment 8 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2003-08-06 03:39:55 PDT
Comment on attachment 129262 [details] [diff] [review]
patch

ah yes. Nice.
Comment 9 Asa Dotzler [:asa] 2003-08-06 16:49:32 PDT
Comment on attachment 129262 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to 1.5beta.
Comment 10 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2003-08-06 17:06:39 PDT
taking
Comment 11 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2003-08-06 17:06:54 PDT
Fix checked in to trunk, 2003-08-06 16:59 -0700.

Note You need to log in before you can comment on or make changes to this bug.