214676 - Need to make icons work for many platforms

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Mike Kaply [:mkaply]]

Currently the icons in the mail/app dir are windows icons. To support OS/2 (and
maybe others)

We should use platform specific icons directories similar to the main trunk.

Makefile patch coming.

Does Unix use ICO files or do we need to create XPM files?

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Makefile change

Also adding directories icons/windows, icons/os2, icons/gtk - using .ico files
for gtk for now?

Or should we create XPM files?

Comment 2

[Scott MacGregor]

Mike, is your makefile change for these icons consistent with how
mozilla\browser\app works?

Comment 3

[Mike Kaply [:mkaply]]

yep it's a block copy.

The only thing I need to solve is if I should copy the ico files into gtk for
now, or create XPM files.

Not that I know how to create XPM files.

Comment 4

[Scott MacGregor]

I'm pretty sure linux doesn't take .ico files. we may need someone to convert
them to xpms. feel free to check in the makefile change at your leisure.

Comment 5

[Pratik]

Mike,

you can create .xpm files by using convert utility e.g.

$ convert msgcomposeWindow.ico msgcomposeWindow.xpm

The problem is that you'll end up with 6 or 7 .xpm files since the .ico has
multiple images. I can create and attach the .xpm files if you want.

Comment 6

[Mike Kaply [:mkaply]]

That would be great. I haven't moved on this bug for lack of xpm files.

Thanks

Comment 7

[Pratik]

Attachment: xpm icons

mkaply,

Here is the tar ball with all the xpm files. There are multiple xpm files for
each icon since the .ico has multiple images.

On another note, I notice that thunderbird on linux now has Mozilla icons.
There are links like the following.

msgcomposeWindow16.xpm ->
/psolanki/thunderbird/mozilla/xpfe/bootstrap/icons/gtk/msgcomposeWindow16.xpm

So icons now work. Its just the wrong icons.

Comment 8

[Pratik]

Comment on attachment 128970 [details] [diff] [review]
Makefile change

>@@ -1,4 +1,4 @@
>-# ***** BEGIN LICENSE BLOCK *****
>+I# ***** BEGIN LICENSE BLOCK *****

typo?

Comment 9

[Brian Ryner (not reading)]

I went ahead and made this change yesterday (not knowing about this bug,
unfortunately).  I used the highest depth 16 and 32 pixel icons in each .ico
file for the XPM.  (gtk2 currently doesn't provide the 16px icon as an
alternative, that's a bug).

Mike, if you have OS/2 icons, feel free to put them in mail/app/icons/os2/.