214707 - Don't allow creation of nameless toolbars

Status: VERIFIED FIXED

(Toolkit :: Toolbars and Toolbar Customization, defect, P4)

Description

[Aaron Kaluszka]

If you create a toolbar, but don't give it a name, it won't show up in the View
-> Toolbars menu.  Firebird 20030731/WinXP

Comment 1

[Wayne Woods]

I don't think you should be allowed to create a nameless toolbar in the first
place. If so, maybe that could be fixed at the same time as bug 171303 (which
deals with some duplicate toolbar name issues). I'll put a comment over there
and see what they think.

Comment 2

[Mike Connor [:mconnor]]

not a 0.9 blocker, maybe for 1.0

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

How about a bug on not being able to create nameless toolbars? ;-) 

Comment 4

[Wayne Woods]

Well, as I said in comment 1, do we allow nameless toolbars, and fix the way
they're represented so they do show up in the list (under a generic name,
presumably), or do we simply not allow nameless toolbars? The latter seems to
make more sense.

Comment 5

[sushi]

(In reply to comment #0)
> If you create a toolbar, but don't give it a name, it won't show up in the View
> -> Toolbars menu.  Firebird 20030731/WinXP

- And also you can delete the new toolbar created, even if you leave it empty.
(Or I don't know how to delete itand i have now a nice grey empty toolbar)
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

Comment 6

[Aaron Leventhal]

Everyone seems to agree on the solution. Changing summary.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Attachment: Patch

Continuously asking until the user enters a name or presses cancel doesn't seem
to be the most elegant option, but it certainly is the easiest. Seeing as how
the current UI does pretty much the same in the case of a duplicate name, I
thought this was acceptable. This UI isn't used very much anyways...

Comment 8

[Aaron Kaluszka]

Would it just be easier/more understandable to disable the OK button while the
input field is empty?

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 176099 [details] [diff] [review]
Patch

bumping review to bsmedberg, no time to test/review this for a little bit.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #8)
> Would it just be easier/more understandable to disable the OK button while the
> input field is empty?

I thought of that, but the prompt service used in this case doesn't allow for
this functionality. The other option would be to use a custom dialog, but I
didn't think it was worth the effort for such a minor thing.

Comment 11

[Steffen Wilberg]

Checking in mozilla/toolkit/content/customizeToolbar.js;
/cvsroot/mozilla/toolkit/content/customizeToolbar.js,v  <--  customizeToolbar.js
new revision: 1.26; previous revision: 1.25
done
Checking in mozilla/toolkit/locales/en-US/chrome/global/customizeToolbar.properties;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/global/customizeToolbar.properties,v
 <--  customizeToolbar.properties
new revision: 1.3; previous revision: 1.2
done