Closed
Bug 21472
Opened 26 years ago
Closed 26 years ago
Illegal usage of LL_CMP(foo,<=,bar)
Categories
(Core :: XPCOM, defect, P3)
Tracking
()
VERIFIED
FIXED
M13
People
(Reporter: sfraser_bugs, Assigned: waterson)
References
Details
(Keywords: verifyme)
Attachments
(1 file)
|
742 bytes,
patch
|
Details | Diff | Splinter Review |
LL_CMP() cannot be used with an operator of <= or >=, because this breaks the
LL_CMP macro on compilers lacking long long (for performance reasons; ask
brendan). This used to be documented in the NSPR header, but that documentation
has since been lost.
Please fix your usages of this macro in nsInt64.h
|
Reporter | |
Updated•26 years ago
|
Component: Browser-General → XPCOM
|
Assignee | |
Updated•26 years ago
|
Status: NEW → ASSIGNED
Target Milestone: M13
|
|
Assignee | |
Comment 2•26 years ago
|
||
|
|
Assignee | |
Comment 3•26 years ago
|
||
sfraser, brendan: could one of you review my changes? replaced e.g. a>=b with
!(a<b)
|
|
||
Comment 4•26 years ago
|
||
r=brendan@mozilla.org,a=brendan@mozilla.org
Isn't wtc fixing the macro to work with non-strict relationals?
/be
|
|
Assignee | |
Updated•26 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•26 years ago
|
||
fix checked in.
|
||
Comment 6•26 years ago
|
||
Chris, I just checked in the fix for the LL_CMP macro.
You can now back out your workaround in nsInt64.h
(attachment 4008 [details] [diff] [review]).
I am assuming per all of you comments, and since this is an old bug that all is
well here. marking Verified. Please reopen if still an open issue.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•