Closed Bug 214754 Opened 21 years ago Closed 19 years ago

remove "Use Default" (broken anyway) from Bookmarks Manager - Move; dialog has no title; increase the default size of the dialog

Categories

(Firefox :: Bookmarks & History, defect, P5)

Product:
Firefox
Component:
Bookmarks & History
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox1.5

People

(Reporter: Lil46john, Assigned: Gavin)

References

Details

(Whiteboard: [asaP1])

Attachments

(1 file, 2 obsolete files)

Updated, fix window persisting
5.56 KB, patch
mconnor
: review+
asa
: approval-aviary1.1a2+
Details | Diff | Splinter Review 
willerg tolde me to do a new bug so here it is
And window is very small, so kind of useless. Maybe it shouldn't even be there
when you have drag/drop
Name's Wilberg. But call me Steffen.

The "Use Default" button was removed from Mozilla so I guess it's obsolete. It
takes you to the root folder as far as I can see.
The "New Folder" button doesn't even work (it does in Mozilla). But I think it
should be fixed instead of removed.
The box is too small, but you can enlarge it and it remembers that. It should be
larger from the beginning though.
Summary: get rid of redundant "new Folder" "Use Default" from "Move → get rid of "New Folder" and "Use Default" from Bookmarks Manager - Move
Just like bug 214527 wants to make the window not so small, while this one is
fixed, it could also be made the window bigger.

But again, why another window for move when you can drag/drop?
> But again, why another window for move when you can drag/drop?
You can't drag and drop with your keyboard. You can hit Alt-M though.
Removing the "use default folder" is a no brainer, since the function it calls
isn't even defined anymore. For "New Folder", I'm not sure why you would want to
remove it. I agree with Steffen that it should be fixed and I'll look into doing
that.
Assignee: p_ch → gavin.sharp
Severity: enhancement → normal
Priority: -- → P5
Target Milestone: --- → Firefox1.1
Version: unspecified → Trunk
The Move dialog has no title in trunk builds. "New Folder" works fine in 1.0 and
trunk. Resummarizing.
Summary: get rid of "New Folder" and "Use Default" from Bookmarks Manager - Move → remove "Use Default" (broken anyway) from Bookmarks Manager - Move; dialog has no title; increase the default size of the dialog
Attached patch Patch v1 (obsolete) — — Splinter Review 
Removes the unused button, fixes the dialog's title, and increases the
tree-view's height slightly.
Attachment #174111 - Flags: review?(mconnor)
Whiteboard: [patch-r?]
Attachment #174111 - Flags: review?(mconnor) → review?(vladimir)
Status: NEW → ASSIGNED
Flags: blocking-aviary1.1?
Attached patch Unbitrotted (obsolete) — — Splinter Review 

        Attachment #174111 -
        Attachment is obsolete: true

        Attachment #178163 -
        Flags: review?(mconnor)

        Attachment #174111 -
        Flags: review?(vladimir)

        Attachment #178163 -
        Flags: review?(mconnor) → review?(vladimir)

    
  
Whiteboard: [patch-r?] → [patch-r?] [asaP1]

    
    

    
  
*** Bug 290370 has been marked as a duplicate of this bug. ***
Flags: blocking-aviary1.1? → blocking-aviary1.1+

        Attachment #178163 -
        Attachment is obsolete: true

        Attachment #178163 -
        Flags: review?(vladimir)

        Attachment #186435 -
        Flags: review?(mconnor) → review+

        Attachment #186435 -
        Flags: approval-aviary1.1a2?
Whiteboard: [patch-r?] [asaP1] → [asaP1][checkin needed]

    
  

        Attachment #186435 -
        Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Whiteboard: [asaP1][checkin needed] → [asaP1][checkin needed][a+]

    
    

    
  
checked in
Whiteboard: [asaP1][checkin needed][a+] → [asaP1][a+]
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [asaP1][a+] → [asaP1]
Depends on: 300988

    
    

    
  
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: