214809 - Download directory textbox and Browse button are enabled when they shouldn't

Status: RESOLVED INVALID

(Firefox :: Settings UI, defect)

Description

[Malte Rücker (mbr)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1

Go to Tools > Options... > General tab.
Under "Download Directory", if "Ask me where to save every file" is selected the
download directory textbox and the browse button are enabled at first but they
should be disabled.

Reproducible: Always

Steps to Reproduce:
1. Open Options dialog, go to "General".
2a. If "Ask me where to save every file" is not selected, check it, click on
another tab like "Privacy" and then go back to "General".
2b. If "Ask me where to save every file" is selected that's just fine.

Actual Results:  
The download directoy textbox and the browser button are enabled.

Expected Results:  
These two elements should be disabled and only be active when "Save all files to
this folder" radio button is selected.

Comment 1

[Malte Rücker (mbr)]

Attachment: patch to add new DoEnabling function

this patch adds a new DoEnabling function that is called at startup and
disables the elements if necessary.
comments are welcome.

Comment 2

[Mike Connor [:mconnor]]

Taking, NEW

Malte, this patch is a start, but this section needs to be slightly reworked now
that the download path can be directly edited (although in the build you posted
with, you won't see that).  The patch for bug 178227 didn't include this because
this behaviour suited my purposes in the short term (wanted to get the feature
out and make sure the impl would work first.

A global DoEnabling is needed, but the automatic SelectFolder() on select is no
longer needed or wanted.

Comment 3

[Mike Connor [:mconnor]]

This bug isn't valid any more with the prefs redesign that  Ben is going to land
with his Download Manager rewrite.

Comment 4

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change