214884 - [ActiveX] Incomplete implementation of IOleCommandTarget interface

Status: RESOLVED EXPIRED

(Core Graveyard :: Embedding: ActiveX Wrapper, enhancement)

Description

[irongut]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624

The Mozilla ActiveX Control's IOleCommandTarget interface is missing many of the
commands present in MS's WebBrowser component. Some of those missing are
standard File and Edit menu commands like Print Preview and Clear Selection. The
commands which are missing from MozillaBrowser.h are:

  OLECMDID_OPEN (= 1)
  OLECMDID_NEW (= 2)
  OLECMDID_SAVE (= 3)
  OLECMDID_SAVECOPYAS (= 5)
  OLECMDID_PRINTPREVIEW (= 7)
  OLECMDID_SPELL (= 9)
  OLECMDID_PASTESPECIAL (= 14)
  OLECMDID_CLEARSELECTION (= 18)
  OLECMDID_ZOOM (= 19)
  OLECMDID_GETZOOMRANGE (= 20)
  OLECMDID_UPDATECOMMANDS (= 21)
  OLECMDID_HIDETOOLBARS (= 24)
  OLECMDID_SETPROGRESSMAX (= 25)
  OLECMDID_SETPROGRESSPOS (= 26)
  OLECMDID_SETPROGRESSTEXT (= 27)
  OLECMDID_SETTITLE (= 28)
  OLECMDID_SETDOWNLOADSTATE (= 29)

I imagine some of these will be impossible to replicate because Gecko doesn't
have the functionality (e.g. _SPELL). I'd like to see the more common and
usefull commands added; e.g. _PRINTPREVIEW, _CLEARSELECTION.

Reproducible: Always

Steps to Reproduce:
1. Embedd the ActiveX control in a windows app
2. Call the ExecWB method with one of the unsupported commands above

Actual Results:  
In Delphi, I get the following exception:
EOleException - Trying to revoke a drop target that has not been registered.

Expected Results:  
Execute the command

Comment 1

[irongut]

Found a complete list of OLECMDID values with explanation of what they do at:
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/com/htm/oen_a2z_22sk.asp

Comment 2

[Sterling Bates]

Attachment: Untested patch for property dialog and "Select None" commands

I haven't been able to compile Moz on my machine lately (says put GLIB_PREFIX
in $path, but it's already there) but these are pretty tiny updates.  I figure
they'll work since I didn't really add much of my own code here :)

Comment 3

[Sterling Bates]

Attachment: Added skeleton code for Print Preview as well

This merely does some of the legwork around getting print preview active.  It
needs to grab a reference to the active frame, plus all the other fun stuff
these routines might need to do.

Comment 4

[irongut]

OLECMDID_SAVEAS doesn't work either. Don't know why I forgot it earlier.

Comment 5

[irongut]

(In reply to comment #4)
> OLECMDID_SAVEAS doesn't work either. Don't know why I forgot it earlier.

OLECMDID_SAVEAS is present, that exception was caused by a problem with args
passed. See bug 225045.

Comment 6

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 7

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.

Comment 8

[Mucha]

This bug still appers.

var Moz: TMozillaBrowser;
Moz.ExecWB(OLECMDID_CLEARSELECTION,OLECMDEXECOPT_DODEFAULT );

Result: EOleException - Trying to revoke a drop target that has not been registered.