214955 - Remove mime.js

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect)

Description

[Stephen Walker]

mime.js was checked in by rhp in mid 1999 and hasn't been changed since; the
three functions don't appear to be used anymore.

Comment 1

[Stephen Walker]

Attachment: Remove the file from jar.mn

Patch doesn't include the cvs removal which should be done.

Comment 2

[Scott MacGregor]

Comment on attachment 129126 [details] [diff] [review]
Remove the file from jar.mn

r/sr=mscott

Please remove the file when you check in of course!

Comment 3

[(not reading, please use [e-mail] instead)]

fix checked into the trunk, for 1.5 final, by mscott.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

So why does mime.js still exist in
http://lxr.mozilla.org/seamonkey/source/mailnews/mime/resources/content/mime.js?

Nothing seems to use it:

http://lxr.mozilla.org/seamonkey/search?string=mime.js

mime.js
/mailnews/extensions/smime/build/nsMsgSMIMEFactory.cpp, line 75 -- { "SMIME JS
Helper",
/mailnews/extensions/smime/Makefile.in, line 35 -- $(INSTALL)
$(srcdir)/resources/content/smime.js $(DIST)/bin/defaults/pref
/mailnews/extensions/smime/Makefile.in, line 38 -- $(SYSINSTALL) $(IFLAGS1)
$(srcdir)/resources/content/smime.js $(DESTDIR)$(mozappdir)/defaults/pref
/mailnews/extensions/smime/jar.mn, line 3 -- content/messenger/am-smime.js
(resources/content/am-smime.js)
/mailnews/extensions/smime/resources/content/Makefile.in, line 30 -- $(INSTALL)
$(srcdir)/smime.js $(DIST)/bin/defaults/pref
/mailnews/extensions/smime/resources/content/Makefile.in, line 33 --
$(SYSINSTALL) $(IFLAGS1) $(srcdir)/smime.js $(DESTDIR)$(mozappdir)/defaults/pref
/mailnews/extensions/smime/resources/content/am-smime.xul, line 38 -- <script
type="application/x-javascript" src="chrome://messenger/content/am-smime.js"/>
/mailnews/extensions/smoketest/resources/content/Makefile.in, line 30 --
$(INSTALL) $(srcdir)/smime.js $(DIST)/bin/defaults/pref
/mailnews/extensions/smoketest/resources/content/Makefile.in, line 33 --
$(SYSINSTALL) $(IFLAGS1) $(srcdir)/smime.js $(DESTDIR)$(mozappdir)/defaults/pref

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Sorry, LXR needs synching.

Bonsai diff shows it's removed:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/mailnews&command=DIFF_FRAMESET&file=jar.mn&rev1=1.66&rev2=1.67&root=/cvsroot

Comment 6

[Eyal Rozenberg]

Why not remove it entirely from the source tree?