If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

xpconnect sample has mismatched progids

RESOLVED FIXED

Status

()

Core
XPConnect
P3
normal
RESOLVED FIXED
18 years ago
18 years ago

People

(Reporter: John Morrison, Assigned: shaver)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

18 years ago
The progid in xpcom/sample/xpconnect-sample.html is

   'component://mozilla/sample/sample-world'

but the progid in xpcom/sample/nsISample.idl is

   'component://netscape/sample'

Cranial damage is the result.

I see that shaver purged the 'gratuitous netscape' from the progid once before.

From n.p.m.xpcom:

Roundeye wrote:
>
> From pulls over the past few days (12/9 through this morning)
> the nsSample module in xpcom/sample appears to be broken (it
> is actually more likely that I am broken but one has to start
> somewhere).
>
> I am on Linux (Mandrake 6.1) and have no particular problems
> pulling, building, and running Mozilla; but whatever I do I
> cannot seem to get the sample module to work.  After a build
> I open (in Mozilla) res://res/res/samples/xpconnect-sample.html.
> I get the message:
>
> Using '/d/devel/src/working/mozilla/dist/bin' as the resource: base
> JavaScript Error: TypeError:
Components.classes["component://mozilla/sample/sample-world"] has no properties
> URL:
file:////d/devel/src/working/mozilla/dist/bin/res/samples/xpconnect-sample.html
> LineNo: 118
>
> when I load the page and a similar message when I try to use
> Get/Set/Poke/Write from the page.  I take this to mean that the
> initialization of the sample JS object fails do to a failure to
> access the C++ xpcom code.
>
> On suggestion from #mozilla I even set:
>
> pref("security.checkuri", false);
> pref("security.checkdomprops", false);
> pref("security.checkxpconnect", false);
>
> in defaults/pref/all.js.
>
> Now what?
> Any help is appreciated.

John Morrison <3jrgm@qlink.queensu.ca> wrote:
>
> It looks like the progid was changed to 'component://netscape/sample'
> (dp Nov 09):
>
> http://lxr.mozilla.org/seamonkey/source/xpcom/sample/nsISample.idl#60
>
>
http://cvs-mirror.mozilla.org/webtools/bonsai/cvsquery.cgi?treeid=default&module
=all&branch=HEAD&branchtype=match&dir=&file=mozilla%2Fxpcom%2Fsample%2FnsISample
.idl&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate
=11%2F01%2F1999&maxdate=12%2F11%2F1999&cvsroot=%2Fcvsroot
>
> If I change from
>  //var sample =
Components.classes["component://mozilla/sample/sample-world"].createInstance();
> to
>    var sample =
Components.classes["component://netscape/sample"].createInstance();
> the component loads (although I haven't really checked any further than that).
>
> Perhaps xpconnect-sample.html needs updating to match the new progid.

Roundeye wrote:

> It works when I change the xpconnect-sample.html component:// instances
> to component://netscape/sample.
>
> So, yes, the xpconnect-sample.html file is out of sync with the
> component code.
>
> Thanks (I've been beating my head on this for 24 hours at least)
>

Updated

18 years ago
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 1

18 years ago
Thanks for finding this!

Fixed the progids in xpconnect-sample.html.
You need to log in before you can comment on or make changes to this bug.