21524 - window.closed incorrectly reported if window closed manually

Status: VERIFIED WORKSFORME

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Tim Musson]

Overview: Say I use JavaScript to open a popup called myWin. If I close it with
myWin.window.close(), myWin.closed returns true. If I close it manually (ie.
using the window close gadget), myWin.closed does not return true. (I assume
this is a bug.)

Test page:
http://homepages.ihug.co.nz/~trmusson/test/winclosed.html

Build ID: 1999111520

Comment 1

[Mike McCabe]

Good testcase!  Thanks for the concise bug report.

I'm not sure who to forward this to... tentatively reassigning it to event
handling.  The DOM functions are right, but somebody implementing the window
close event isn't letting the DOM know about it.

Comment 2

[rods (gone)]

I am not sure I understand this bug as it sits. From reviewing the JavaScript I
can't see where myWin.closed would be called when it is manually closed.

If you could insert a JS "alert" call where something is being called in when
the window closes manually and this works on 4.x and not in mozilla then I will
have something I can test. (Also, keep mind that when you test in mozilla the
alert will beep but a dialog will not show, so you can use "dump" instead, and
look at the console window)

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

See bug 18301.

Comment 4

[Tim Musson]

Attachment: Testcase showing window closed problem (bug 21524) in milestone 11

Comment 5

[Tim Musson]

The bug is fixed in my copy of milestone 12 (BuildID: 1999122023).

Comment 6

[ekrock's old account (dead)]

Moving M17.

Comment 7

[ekrock's old account (dead)]

Bulk moving [testcase] code to new testcase keyword. Sorry for the spam!

Comment 8

[leger]

Setting the keyword all open [4.xp] bugs to 4xp.

Comment 9

[joki (gone)]

Seems to work okay for me as well.  Marking WORKSFORME.

Comment 10

[WD]

Verified 200092808

Comment 11

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/c313befe9ba7
[fenix] Inactive tabs changes (https://github.com/mozilla-mobile/fenix/pull/21524)