215259 - Calendar color reset to default when edit window is opened.

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Brian Redmond]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1

Instead of the custom color for a calendar being selected when the edit calendar
window is opened, the color is reset to the default color everytime the window
is opened.

Reproducible: Always

Steps to Reproduce:
1. Under the Calendars tab, right-click on a calendar and select 'Edit Calendar'.
2. Choose a color for the calendar and click OK. (works fine)
3. Right-click and select 'Edit Calendar' on the same calendar.
(color selection is reset to default).

Actual Results:  
The color selection resets to the default color when the edit window is opened.

Expected Results:  
The selected color for the calendar should remain as the selected color in the
edit window.

Comment 1

[Mike Loll]

I also noticed this behaviour - if you create a new calendar AND you specify a
default color, then you CAN change the calendar color later on as described in
the bug's original report.  However, the bug surfaces when you create a new
calendar but do NOT specify a default color before saving the new calendar.

Steps to Reproduce the Correct Functionality:
1) Open Calendar.
2) Click on the "File->New Calendar" menu command.
3) Type in a calendar name (example: "BUG 215259 TEST").
4) Click the color picker and choose a color (example: RED).
5) Click the OK button.
6) Close Calendar.
7) Open Calendar.
8) Click on the Calendars tab.
9) Right-click on the "BUG 215259 TEST" calendar and choose Edit Calendar.
10) Click the color picker and choose a color (example: BLUE).
11) Click the OK button.
12) Close Calendar.
13) Open Calendar.
14) Click on the Calendars tab.  The new color chosen in step 10 will be present
for calendar "BUG 215259 TEST".

If you omit step #4, step #14 will fail (thus showing the bug).  Also, closing
and opening Calendar has no affect on whether the bug is shown or not.

Comment 2

[Mike Loll]

I've begun working on a fix for this (in order to familiarize myself with 
XUL/JS).  I think I have a working patch - I'll post to the newsgroup later 
today (and attach my patch here) later tonight.

Comment 3

[Mike Loll]

Attachment: Patch for calendar/resources/content/calendarManager.js

Patch created using WinCVS1.3.13.2 Beta 13.

Because of the way the color picker returns an unselected color (i.e. a user
does not select a calendar default color), it was affecting how the calendar
data was being read in.  I am still a bit unclear on why this was happening. 
Nevertheless,  when using a default color of 'transparent' when a user does not
select a calendar color, the bug is not present.

I would greatly appreciate any insight into why CalendarObject.color could not
be set with node.setAttribute.	I would conjecture it has something to do with
how node.setAttribute handles undefined data(?).

Comment 4

[Eric Belhaire]

Comment on attachment 136270 [details] [diff] [review]
Patch for calendar/resources/content/calendarManager.js

review asked

Comment 5

[Mostafa Hosseini]

Comment on attachment 136270 [details] [diff] [review]
Patch for calendar/resources/content/calendarManager.js

Thanks for spotting the problem. Nice fix too.
Just a small request: Can you default to #F9F4FF instead of "transparent" for
the default calendar color? Because so far we've been using that one.

I've fixed the extra carriage returns which you've removed in your patch too so
please cvs update if you make a new patch.

Comment 6

[Mike Loll]

Attachment: New Patch with #F9F4FF Color

Here is a new patch as per Mostafa's comment (#5).

Comment 7

[Mostafa Hosseini]

Checked into CVS.
Thanks.

Comment 8

[Simon Paquet [:sipaq]]

Comment on attachment 136270 [details] [diff] [review]
Patch for calendar/resources/content/calendarManager.js

Patch is obsolete

Comment 9

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!