215384 - "Group by date" often sorts incorrectly

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Brian Ryner (not reading)]

If you select a grouping other than "by date" in the history sidebar, then
switch back to group by date, the folders become sorted alphabetically, i.e.

2 days ago
3 days ago
Today
Yesterday

instead of chronologically:

Today
Yesterday
2 days ago
3 days ago

Comment 1

[Brian Ryner (not reading)]

-> me

Comment 2

[Brian Ryner (not reading)]

Attachment: patch

My attempt at fixing the problem... this adds a new property for the day
folders which gives the index (0-7) to be used for sorting.  In addition, I
removed the hidden columns from the tree and instead just change the "sort"
attribute on the name column to the property to sort on (per conversation with
waterson, the template code currently requires the sort key to be part of the
template, which is why I made all of the possible sort keys be attributes on
the treeitems.)

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 129350 [details] [diff] [review]
patch

Cool. r=[e-mail]

Comment 4

[Brian Ryner (not reading)]

checked in.

Comment 5

[Simon Paquet [:sipaq]]

Verified.

Comment 6

[Simon Paquet [:sipaq]]

Verified.