215590 - "Copy Link Location", "Delete", "Select All" in history sidebar do not work/are inactive/greyed out

Status: RESOLVED FIXED

(Core Graveyard :: History: Global, defect)

Description

[Steffen Wilberg]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030807
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030807

In history sidebar, the context menu items "Copy Link Location", "Delete" and
"Select All" in history sidebar do not work. They do work in Go - History.

Reproducible: Always

Steps to Reproduce:
1. Open the history sidebar.
2. Right-click on any item.

Actual Results:  
If you right-click on a hostname, the context menu items "Delete" and "Select
All" are inactive (greyed out).
If you right-click on a page, the context menu items "Copy Link Location",
"Delete" and "Select All" are inactive.

Expected Results:  
These items should work.

Workaround: There's no problem in Go - History (Ctrl-H).

Comment 1

[Andreas Kunz]

Error: gHistoryStatus has no properties
Source File: chrome://communicator/content/history/history.js
Line: 164

in JavaScript console when this happens.
This might point to bug 227053.

Comment 2

[Andreas Kunz]

Delete button is bug 140616.

Comment 3

[Andreas Kunz]

Yes, I commented out the line with the error and now the script runs on and this
bug disappears - at least most parts of it:
Starting with the second right-click everything works. But at the first time
"Delete" and "Copy Link Location" are still greyed out.
So this bug depends on bug 227053, but is not fully identical.

Comment 4

[Andreas Kunz]

My last comment now represents the state of the trunk.

The default selection somehow does not select the first item completely or too
late...

Comment 5

[Andreas Kunz]

Attachment: patch

Update commands when focus goes to tree.

Comment 6

[Andreas Kunz]

Comment on attachment 139200 [details] [diff] [review]
patch

Requesting sr= from alecf.

Comment 7

[Alec Flett]

Comment on attachment 139200 [details] [diff] [review]
patch

does this also update the "delete domain" option too?

Comment 8

[Andreas Kunz]

alecf: ummm... in the history sidebar there is no such option and this fix is
for the sidebar only (history-panel.xul). 
I guess you mean the entries in the edit menu of the history window? Bug 148959
is about them and I tried the same thing there, but it does not work. Yesterday
I tried hard to debug that other bug (after having tried and commented the day
before), but I have no idea what's going on there...
Thanks for sr!

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in xpfe/components/history/resources/history-panel.xul;
/cvsroot/mozilla/xpfe/components/history/resources/history-panel.xul,v  <-- 
history-panel.xul
new revision: 1.19; previous revision: 1.18
done