nsDOMCSSDeclaration has NS_DECL_ISUPPORTS, so gets an mRefCnt member. DOMCSSDeclarationImpl inherits from nsDOMCSSDeclaration but DOMCSSDeclarationImpl overrides addref/release to aggregate with its style rule, which means that DOMCSSDeclarationImpl has an unused mRefCnt member. The NS_DECL_ISUPPORTS should be pushed down into nsDOMCSSAttrDeclaration, and nsDOMCSSDeclaration will just have some pure virtual methods, which is fine -- we don't want anyone instantiating objects of that class anyway.
OS: Linux → All
Priority: -- → P2
Hardware: PC → All
Summary: DOM CSS declarations can have extra mRefCnt member → [FIX]DOM CSS declarations can have extra mRefCnt member
Target Milestone: --- → mozilla1.6alpha
Comment on attachment 129560 [details] [diff] [review] proposed patch >+ NS_DECL_ISUPPORTS Could you expand this, and skip the QueryInterface. I object to the existence of NS_IMPL_QUERY_INTERFACE_INHERITED0. >+NS_IMPL_ADDREF(nsDOMCSSAttributeDeclaration); >+NS_IMPL_RELEASE(nsDOMCSSAttributeDeclaration); No need for semicolons.
Created attachment 129561 [details] [diff] [review] Patch updated to comments
Attachment #129560 - Attachment is obsolete: true
16 years ago
Summary: [FIX]DOM CSS declarations can have extra mRefCnt member → [FIXr]DOM CSS declarations can have extra mRefCnt member
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.