[FIXr]DOM CSS declarations can have extra mRefCnt member

RESOLVED FIXED in mozilla1.6alpha

Status

()

P2
normal
RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

Trunk
mozilla1.6alpha
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

nsDOMCSSDeclaration has NS_DECL_ISUPPORTS, so gets an mRefCnt member.
DOMCSSDeclarationImpl inherits from nsDOMCSSDeclaration but
DOMCSSDeclarationImpl overrides addref/release to aggregate with its style rule,
which means that DOMCSSDeclarationImpl has an unused mRefCnt member.

The NS_DECL_ISUPPORTS should be pushed down into nsDOMCSSAttrDeclaration, and
nsDOMCSSDeclaration will just have some pure virtual methods, which is fine --
we don't want anyone instantiating objects of that class anyway.
(Assignee)

Updated

16 years ago
OS: Linux → All
Priority: -- → P2
Hardware: PC → All
Summary: DOM CSS declarations can have extra mRefCnt member → [FIX]DOM CSS declarations can have extra mRefCnt member
Target Milestone: --- → mozilla1.6alpha
Comment on attachment 129560 [details] [diff] [review]
proposed patch

>+  NS_DECL_ISUPPORTS

Could you expand this, and skip the QueryInterface.  I object to the existence
of NS_IMPL_QUERY_INTERFACE_INHERITED0.

>+NS_IMPL_ADDREF(nsDOMCSSAttributeDeclaration);
>+NS_IMPL_RELEASE(nsDOMCSSAttributeDeclaration);

No need for semicolons.
(Assignee)

Updated

16 years ago
Attachment #129560 - Flags: superreview?(dbaron)
Attachment #129560 - Flags: review?(dbaron)
(Assignee)

Updated

16 years ago
Attachment #129560 - Flags: superreview?(dbaron)
Attachment #129560 - Flags: superreview-
Attachment #129560 - Flags: review?(dbaron)
Attachment #129560 - Flags: review-
Created attachment 129561 [details] [diff] [review]
Patch updated to comments
Attachment #129560 - Attachment is obsolete: true
(Assignee)

Updated

16 years ago
Summary: [FIX]DOM CSS declarations can have extra mRefCnt member → [FIXr]DOM CSS declarations can have extra mRefCnt member
Checked in.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.