215768 - nsAutoPtr is used where nsAutoArrayPtr should've been used : nsUTF8ConverterService.cpp

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Jungshik Shin]

While fixing bug 162765, I made a mistake of using nsAutoPtr instead of
nsAutoArrayPtr in nsUTF8ConverterService.cpp

I'm gonna upload a patch (2-liner) that also uses a better workaround for bug
210297 that I forgot to land.

Comment 1

[Jungshik Shin]

Attachment: a patch (2-liner)

I guess using nsAutoPtr (delete) in place of nsAutoArrayPtr (delete []) can
lead to 'who knows what'. It's curious nothing has yet been reported.

Comment 2

[Jungshik Shin]

Comment on attachment 129575 [details] [diff] [review]
a patch (2-liner)

asking for r/sr. it's a simple fix but is necessary to prevent a potential
diaster.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 129575 [details] [diff] [review]
a patch (2-liner)

sr=bzbarsky.

Using delete instead of delete[] has no bad side effects that I know of apart
from not calling destructors of things in the array (not an issue here) and
possibly leaking most of the array (which would not be so cool, but would not
obviously explode).

I think we would really like this for 1.5b, though, since the memory leak
aspect could be a little unfortunate.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I've never heard of using |delete[]| instead of |delete| causing partial leaks.
 (It could cause other problems if the system is using different allocators for
|new| and |new[]|, which is theoretically possible, although unlikely.)

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 129575 [details] [diff] [review]
a patch (2-liner)

a=asa (on behalf of drivers) for checkin to Mozilla 1.5beta.

Comment 6

[Jungshik Shin]

patch checked in. thanks all