Closed Bug 215831 Opened 21 years ago Closed 21 years ago

fix autocomplete tree assertions (blank lines)

Categories

(SeaMonkey :: Autocomplete, defect)

Product:
SeaMonkey
Component:
Autocomplete
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: neil, Assigned: hewitt)

References

Details

(Keywords: regression)

Attachments

(1 file)

Fixed patch
2.96 KB, patch
janv
: review+
jag+mozilla
: superreview+
asa
: approval1.5+
Details | Diff | Splinter Review 
Based on work I did for bug 212220, but I since found a bug in that patch.
Attached patch Fixed patch — — Splinter Review 

    
    

    
  
Comment on attachment 129598 [details] [diff] [review]
Fixed patch

FYI, the bug in the patch in bug 212220 was that I didn't clear the results
early enough.

Jan, do you think I've got the correct amount of batching?

        Attachment #129598 -
        Flags: superreview?(jag)

        Attachment #129598 -
        Flags: review?(varga)

    
    

    
  
Comment on attachment 129598 [details] [diff] [review]
Fixed patch

looks good

        Attachment #129598 -
        Flags: review?(varga) → review+

    
    

    
  
Comment on attachment 129598 [details] [diff] [review]
Fixed patch

sr=jag

        Attachment #129598 -
        Flags: superreview?(jag) → superreview+

    
    

    
  
Comment on attachment 129598 [details] [diff] [review]
Fixed patch

This also fixes an autocomplete display issue (missing lines/extra blank lines)
in release builds (debug builds assert and use fallback code instead).

        Attachment #129598 -
        Flags: approval1.5?

    
    

    
  
Is bug 217662 dupe of this?

    
    

    
  
*** Bug 217662 has been marked as a duplicate of this bug. ***

    
  
Keywords: regression
Summary: fix autocomplete tree assertions → fix autocomplete tree assertions (blank lines)

    
  
Flags: blocking1.5?

    
    

    
  
Comment on attachment 129598 [details] [diff] [review]
Fixed patch

a=asa (on behalf of drivers) for checkin to Mozilla 1.5

        Attachment #129598 -
        Flags: approval1.5? → approval1.5+

    
    

    
  
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED

    
  
Flags: blocking1.5?
Product: Core → Mozilla Application Suite

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: