No way to tab to attachment pane using keyboard

VERIFIED FIXED

Status

MailNews Core
Composition
VERIFIED FIXED
14 years ago
9 years ago

People

(Reporter: Yuliy Pisetsky, Assigned: Yuliy Pisetsky)

Tracking

({access})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

14 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5b) Gecko/20030805
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5b) Gecko/20030805

When composing a message, after attaching a file, you should be able to tab over
to the attachment pane to delete it using keyboard. However even with a file
attached, still cannot tab over

Reproducible: Always

Steps to Reproduce:
1. open mailnews, click compose
2. attach any file
3. try to tab into attachment pane (should be between subject and body according
to the .js file)

Actual Results:  
Goes right past it (from subject to body and body to subject)

Expected Results:  
tabbed from subject to attachments and shift-tabbed from body to attachments

Attaching a patch that might fix this
(Assignee)

Comment 1

14 years ago
Created attachment 129604 [details] [diff] [review]
fixes typo in AttachmentElementHasItems() in MsgComposeCommands.js

what do I do with this now?
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Updated

14 years ago
Attachment #129604 - Flags: review?(sspitzer)
(Assignee)

Updated

14 years ago
Attachment #129604 - Flags: review?(sspitzer) → review?(mscott)

Comment 2

14 years ago
Comment on attachment 129604 [details] [diff] [review]
fixes typo in AttachmentElementHasItems() in MsgComposeCommands.js

Scott, David can you please review?
Attachment #129604 - Flags: superreview?(bienvenu)
Attachment #129604 - Flags: review?(mscott)
Attachment #129604 - Flags: review?(mscott)

Updated

14 years ago
Attachment #129604 - Flags: superreview?(bienvenu) → superreview+

Comment 3

14 years ago
Scott or I can check this in for you...

Comment 4

14 years ago
Thanks David. That would be nice. And just to rule out any misunderstandings. I
only seeked review, npisetsky@cox.net wrote the patch and should be credited.

Another question: 
Since this is a pretty low-risk patch, should I ask for approval for 1.4.2, too?

Comment 5

14 years ago
you can seek approval - I'm not sure if it would be considered important enough
for 1.4.2, even though it is low risk.

Comment 6

14 years ago
Comment on attachment 129604 [details] [diff] [review]
fixes typo in AttachmentElementHasItems() in MsgComposeCommands.js

no this should just got into the 1.6 trunk and not a point release for previous
releases. The issue isn't severe enough to warrent that.
Attachment #129604 - Flags: review?(mscott) → review+

Comment 7

14 years ago
I won't seek approval for the 1.4-BRANCH. So if you David or Scott could check
this into the trunk, that would be great.

Comment 8

14 years ago
sure, I'll check it in.

Comment 9

14 years ago
this patch didn't work for me, unfortunately. I'll try a cleaner rebuild.
(Assignee)

Comment 10

14 years ago
Okay, I still think that fix is valid, but I did some poking as to why it didn't
fix the problem at hand, and I found that in 2003102804, I couldn't get it to go
to the attachment pane, _even if I disabled the check for attachments in the
pane_. It still went right on past it. 
(Assignee)

Comment 11

14 years ago
(sry for spam, just realized comment was unclear) the check I referred to in the
previous comment is in the SwitchElementFocus function in the same .js file

Comment 12

14 years ago
I agree - it seems neccesary but not sufficient. I guess I'll check it in and we
can figure out what else is broken.
(Assignee)

Comment 13

14 years ago
Okay. I looked around a bit in messengercompose.xul, and apparently trying to
tab from subject calls subjectKeyPress instead of SwitchElementFocus. Another
thing: apparently, SwitchElementFocus is broken. It is only used when using
ctrl+tab or F6 (see <a
href="http://lxr.mozilla.org/mozilla/source/mailnews/compose/resources/content/messengercompose.xul#175">http://lxr.mozilla.org/mozilla/source/mailnews/compose/resources/content/messengercompose.xul#175</a>
). Using F6 from the message panejumps to the identity, F6/ctrl+tab after that
jumps back to the content pane. shift+F6 from the subject even leaves it there.
I'll try looking into what's going on there
Status: NEW → ASSIGNED
Over to Yuliy.
Assignee: sspitzer → npisetsky
Status: ASSIGNED → NEW

Comment 15

14 years ago
i've checked in the fix for the typo with a larger checkin for cancelling fcc
operations.

Comment 16

14 years ago
Created attachment 136476 [details] [diff] [review]
This should fix the remaining issues

I renamed addressingWidgetTree because it's not a tree, which makes the patch
bigger than it seems, the relevant parts are lines 2310, 2556, 2717 and 2745.
(Assignee)

Updated

14 years ago
Status: NEW → ASSIGNED

Updated

14 years ago
Attachment #136476 - Flags: review?(mscott)

Updated

14 years ago
Attachment #136476 - Flags: superreview?
Attachment #136476 - Flags: review?(mscott)
Attachment #136476 - Flags: review+

Comment 17

14 years ago
Comment on attachment 136476 [details] [diff] [review]
This should fix the remaining issues

we need to do the same fix in tbird, I believe.
Attachment #136476 - Flags: superreview? → superreview+

Comment 18

14 years ago
Fix checked in to Seamonkey.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED

Updated

14 years ago
Keywords: access
(Assignee)

Comment 19

14 years ago
one last thing. ctrl+tab or F6 from subject goes to attachments if there are
attachments, as it should be, but tab does not. Why is there a separate function
to handle a tab in the subject line?
(Assignee)

Updated

14 years ago
Status: RESOLVED → VERIFIED

Comment 20

14 years ago
To follow up on Yuriy's comment 19: Shift-tab from the body doesn't go to the 
Attachments pane either; shift-Ctrl-Tab or shift-F6 do.  Is that intentional, or 
should there be a new bug opened?

See also bug 236219.

Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.