Closed Bug 216025 Opened 21 years ago Closed 21 years ago

preprocessor.pl doesn't track current directory correctly

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: bryner, Assigned: bryner)

Details

Attachments

(1 file)

patch
4.11 KB, patch
hyatt
: review+
Details | Diff | Splinter Review 
preprocessor.pl intends to search for #included files in the directory where the
currently-being-processed source file resides, however, there is a bug which
makes it always search relative to the directory preprocessor.pl was run from.

This is breaking firebird objdir builds.
Attached patch patch — — Splinter Review 
fixes the bug, which I think is due to incorrect |local| scoping.

Also, fix up all include statements in browser.xul to have paths relative to
browser.xul.
Comment on attachment 129723 [details] [diff] [review]
patch

r=hyatt
Attachment #129723 - Flags: review+
Ian checked in a better version of the preprocessor.pl change, and I checked in
the #include changes for Firebird.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
verified
Status: RESOLVED → VERIFIED
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: