216154 - Anchors in e-mails are broken (Clicking Anchor doesn't go to target in e-mail) (is not a registered protocol)

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Peter Lairo]

User-Agent:       Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.5b) Gecko/20030810
Build Identifier: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.5b) Gecko/20030810

Anchors in e-mails are broken (Clicking Anchor doesn't go to target in e-mail)

Reproducible: Always

Steps to Reproduce:
1. receive an HTML e-mail that contains anchors (e.g., GameSpy newsletter)
2. Click on table of Contents item (that should take you to article further down)
Actual Results:  
- e-mail doesn't scroll to anchored location
- Error message appears (see screenshots)

Expected Results:  
- e-mail is scrolled to anchored location (further down in e-mail).

Comment 1

[Peter Lairo]

Attachment: Screenshot showing anchor link in statusbar

Comment 2

[Peter Lairo]

Attachment: Screenshot of Error Message after clicking the anchor link

Comment 3

[Alfonso Martinez]

*** Bug 214416 has been marked as a duplicate of this bug. ***

Comment 4

[Peter Lairo]

Attachment: Testcase: An e-mail that triggers this bug

Comment 5

[Peter Lairo]

Interestingly, the anchors *do* work when opening the HTML e-mail in the
browser; but they do *not* work in mail-news.

Comment 6

[Andreas Otte]

Broken base url?

Comment 7

[Peter Lairo]

Unlikely, because this bug exists now for *all* e-mails (completely unrelated to
each other) i receive that have anchors. In older mozilla versions, the anchors
all used to work.

Comment 8

[Andreas Otte]

I was refering to a possible change that broke the base-url in mailnews.

Comment 9

[Matthias Versen [:Matti]]

*** Bug 216864 has been marked as a duplicate of this bug. ***

Comment 10

[Matthias Versen [:Matti]]

*** Bug 217722 has been marked as a duplicate of this bug. ***

Comment 11

[Jerry Baker]

*** Bug 219340 has been marked as a duplicate of this bug. ***

Comment 12

[Alfonso Martinez]

*** Bug 220048 has been marked as a duplicate of this bug. ***

Comment 13

[Alfonso Martinez]

updating summary

Comment 14

[Boris Zbarsky [:bzbarsky]]

The base URL may have been broken all along, but anchor scrolling was recently
changed to use nsIURI instead of strings.

Comment 15

[[e-mail]]

Debug warning:

WARNING: malformed url: no scheme, file
c:/mozilla/netwerk/base/src/nsStandardURL.cpp, line 686

Comment 16

[Andreas Otte]

Hmmm ... one of the first steps when clicking on a link is resolving the link to
a new complete url. This also happens with anchors. The debug message indicates
that the resolving process results in a string that can not be identified as an
url. I see only one options here: The base url is already invalid (or not
existing) before the resolving ... the result does not change that. Maybe
switching to nsIURI (as Boris mentioned) caused the baseurl to get lost or
getting invalid. The link-strings from the testcase look ok, so I don't think
they can be the reason.

Comment 17

[Boris Zbarsky [:bzbarsky]]

Neil, what is the string that necko is passed when you get that warning?  The
stack for the warning should be under TriggerLink().  What is the baseURI there?

Comment 18

[[e-mail]]

The baseURI looks fine, but unfortunately nsMailboxService::NewURI appears to
ignore it, unless the spec contains "?uidl" or "&uidl" for some pop3 reason.

Comment 19

[Boris Zbarsky [:bzbarsky]]

More mail URI mess....

Comment 20

[Boris Zbarsky [:bzbarsky]]

*** Bug 221089 has been marked as a duplicate of this bug. ***

Comment 21

[Matthias Versen [:Matti]]

*** Bug 222170 has been marked as a duplicate of this bug. ***

Comment 22

[John Rocha]

I've observed that these email links to anchors within the email do work with
other email readers, just not with Mozilla 1.5 email reader.

I double checked with UNIX netscape communicater 4.77 email reader and the links
work fine there.  So I believe the links are valid, just not working correctly
within the email reader.

Comment 23

[Rollin Denniston]

Surprised this bug wasn't fixed in Moz 1.5 release as it is clearly regressive
to Moz 1.4.1, that is, the anchors worked fine in 1.4.1, not in any version of
1.5 so far. I haven't checked to see if the same bug occurs in FBird.

Comment 24

[Boris Zbarsky [:bzbarsky]]

*** Bug 222434 has been marked as a duplicate of this bug. ***

Comment 25

[Onno]

Mail are also broken when you send it with moz 1.5

Comment 26

[Ed Taylor]

Sorry, but is this bug being worked on? It has been out there for a very long
time.. 

Comment 27

[Andreas Otte]

I will try to take a look starting with neil's comment #18, can anybody send me
such an email for tests.

Comment 28

[Rein Smedinga]

Attachment: email with ancors

Comment 29

[Rein Smedinga]

Added an attachment with an email with ancors that do not work.

Comment 30

[Andreas Otte]

Thanks to all sending me testmails ... I think I have a fix for this. Neil was
right. Unfortunally I already have a patched nsMailboxService.cpp from bug 93666
... the bug is more than 2 years old ... the patch rots away for more than half
a year now ... still assigned to a netscape.com address. So this needs a little
bit more work from my side.

Comment 31

[Andreas Otte]

Attachment: This patch fixes the problem for me ... please apply and test

Comment 32

[[e-mail]]

Comment on attachment 134706 [details] [diff] [review]
This patch fixes the problem for me ... please apply and test 

OK, so this does appear to fix the problem for POP3 and local accounts, but not
IMAP and presumably not news either.

>     nsCOMPtr<nsIMailboxUrl> aMsgUrl;
>     nsresult rv = NS_OK;
>     nsACString::const_iterator b, e;
>+    nsCString newSpec;
Should be defined where it is used... but then again, so should aMsgUrl ;-)

>+      if (!aBaseURI) {
>+        aUrl->SetSpec(aSpec);
>+      } else {
>+        aBaseURI->Resolve(aSpec,newSpec);
>+        aUrl->SetSpec(newSpec);
>+      }
Brace style in this file is each brace on its own line.

Comment 33

[Boris Zbarsky [:bzbarsky]]

See
http://lxr.mozilla.org/seamonkey/source/mailnews/news/src/nsNntpService.cpp#1468
for news://

See
http://lxr.mozilla.org/seamonkey/source/mailnews/local/src/nsPop3Service.cpp#279
(probably only used for actual POP retrievals).

See
http://lxr.mozilla.org/seamonkey/source/mailnews/imap/src/nsImapService.cpp#2626
for IMAP.

None of these do the right thing.

Comment 34

[Andreas Otte]

Attachment: beautified patch

patch beautified and extended for imap and news. I left pop3Service out, I
don't think it makes sense there.

Comment 35

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 134730 [details] [diff] [review]
beautified patch

sr=bzbarsky if you switch to nsCAutoString and put spaces between "," and
"newSpec" in the Resolve() calls...

bienvenu, what do you think?

Comment 36

[David :Bienvenu]

Comment on attachment 134730 [details] [diff] [review]
beautified patch

yes, r=bienvenu, with the same conditions as bz (nsCAutoString, formatting...)
and no, nsPop3Service is not needed for this.

Comment 37

[Matthias Versen [:Matti]]

*** Bug 215248 has been marked as a duplicate of this bug. ***

Comment 38

[[e-mail]]

Patch tweaked slightly and checked in.

Comment 39

[Boris Zbarsky [:bzbarsky]]

*** Bug 224690 has been marked as a duplicate of this bug. ***

Comment 40

[Peter Lairo]

Thanks Neal. :) Another of my most-hated bugs fixed by you. You're rapidly
turning into my mozilla-hero-of-the-year. ;)

Comment 41

[Ed Taylor]

As a user, I also thank you Neal!  The nightly windows update seems to be frozen
at 28-Oct-2003. When will this patch be applied..

Thanks Again...
 
  

Comment 42

[Rollin Denniston]

The build at http://frp.pryan.org/firebird/mozjf/ includes the patch for this bug.

I've got it working right now and all looks good.

It does have the calendar built in but that can be removed if you don't want it.

Comment 43

[Ed Taylor]

Sorry Rollin, 

but I am looking for the Mozilla updated version not firebird.

Comment 44

[Rollin Denniston]

The good mozilla build which includes the fix for this bug has been moved to
http://frederic.bezies.free.fr/weblog/mozilla/

Sorry about the earlier misdirection.

Comment 45

[Alfonso Martinez]

*** Bug 225154 has been marked as a duplicate of this bug. ***

Comment 46

[Alfonso Martinez]

*** Bug 225581 has been marked as a duplicate of this bug. ***

Comment 47

[Alfonso Martinez]

*** Bug 225600 has been marked as a duplicate of this bug. ***

Comment 48

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 225975 has been marked as a duplicate of this bug. ***

Comment 49

[Boris Zbarsky [:bzbarsky]]

*** Bug 226083 has been marked as a duplicate of this bug. ***

Comment 50

[Alfonso Martinez]

*** Bug 226966 has been marked as a duplicate of this bug. ***

Comment 51

[Alfonso Martinez]

*** Bug 227443 has been marked as a duplicate of this bug. ***

Comment 52

[Mike Cowperthwaite]

*** Bug 233042 has been marked as a duplicate of this bug. ***