216170 - Send Page (as Link) omits query string

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Aaron Kaluszka]

The patch for bug 173954 is insufficient because the query string of the URL is
not passed to the mail client.  Many pages need the query string to return the
correct content.

Comment 1

[Jon Henry]

This bug is potentially a dupe of bug 217328 (or the other way around), which
affects both SeaMonkey and Firebird. Unless I misunderstand the term query
string, or if the problem lies in the toolkit and would need to be ported to
Firebird after fixing it in SeaMonkey anyway.

Comment 2

[Jon Henry]

Bug 217328 now has a patch with r/sr, will that be difficult to port to
Firebird? I'll give it a try tonight perhaps, although I've been having trouble
with my firewall and CVS recently.

Comment 3

[Oliver]

when i try to "Send Page..." from "File" menu, with the following URL

http://www.filmstarts.de/kritik/findet%20nemo.html

the URL in Outlook Express ends up in

http://www.filmstarts.de/kritik/findet nemo.html

(%20 will be converted to space, not wrong, but the URL will become unusable)

Comment 4

[Jon Henry]

Attachment: Proposed patch

I apologize if I bungle this process, since this is the first patch I've ever
submitted. It's basically identical to the patch from bug 217328 except it's
applied to the browser component rather than SeaMonkey.

Comment 5

[Jon Henry]

Comment on attachment 136057 [details] [diff] [review]
Proposed patch

Requesting review for one-line change, have tested successfully on my system.

Comment 6

[Simon Paquet [:sipaq]]

Comment on attachment 136057 [details] [diff] [review]
Proposed patch

Review is sufficient for firebird.

Comment 7

[Aaron Kaluszka]

Does that fix the query string problem as well as the space problem?  If it only
fixes the latter, a new bug should be filed for that.

Comment 8

[Jon Henry]

In my testing, it fixed both.

Comment 9

[Jon Henry]

Comment on attachment 136057 [details] [diff] [review]
Proposed patch

Trying another reviewer, I didn't realize that Ben doesn't read bugmail.

Comment 10

[Jon Henry]

Attachment: Updated patch

In light of the recent change to the escape function, I've updated this patch
to use encodeURLComponent instead to match the rest of the tree.

Comment 11

[Jon Henry]

Comment on attachment 136883 [details] [diff] [review]
Updated patch

Asking for review of updated patch.

Comment 12

[Jon Henry]

0.8 could live without this patch landing, but it would be nice to get in as
it's one line and makes Send Link useful again.

Comment 13

[Mike Connor [:mconnor]]

Comment on attachment 136883 [details] [diff] [review]
Updated patch

Pierre, this seems obvious and trivial enough to go into 0.8, can you take a
look please?

Comment 14

[Jason Barnabe (np)]

*** Bug 229850 has been marked as a duplicate of this bug. ***

Comment 15

[Pierre Chanial]

checked in both branch and trunk.
For the branch, I added a null check for title because of the encodeURIComponent
bug.

Comment 16

[Bill Mason]

Verified fixed on the trunk, 20030119 PC/WinXP

Comment 17

[alanjstr]

Pre-release cleanup

Comment 18

[Michel Poleur]

Hmmm. The patch has not been integrated into 0.8... :-(

Comment 19

[Aaron Kaluszka]

This patch is not present in 20040320.  Did it get lost somewhere?

Comment 20

[Mike Connor [:mconnor]]

Works for me using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a)
Gecko/20040501 Firefox/0.8.0+

Aaron, still seeing this?

Comment 21

[Aaron Kaluszka]

Well, it doesn't work when sending to Eudora.  I think it's because it sends ?
instead of the ASCII escape equivalent.  If you say it's working with other
programs, I'll open another bug to fix the ? problem.

Comment 22

[Mike Connor [:mconnor]]

yeah, it works for Thunderbird.  File another bug, like you said :)

Comment 23

[pd]

I concur this is still a problem (always has been) for Eudora users such as
myself. It happens with both Eudora 5 and 6 on Windows 2000 and XP operating
systems specifically.

Comment 24

[Aaron Kaluszka]

Unfortunately that is a bug in Eudora.  I think the only way to fix this from
the Mozilla side is to fix bug 251036.