21618 - JS "var" incompatibility due to ECMA changes

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Brendan Eich [:brendan]]

All scripts in(cluded in) a page should be treated as one JS program under ECMA
Edition 3.  I busted that recently making ECMA changes for the single script tag
case.  Will fix ASAP.

/be

Comment 1

[Brendan Eich [:brendan]]

Attachment: proposed fix

Comment 2

[Brendan Eich [:brendan]]

Need code reviews ASAP.  Thanks,

/be

Comment 3

[rogerl (gone)]

Did you get a review on this? The attachment is missing the definition for
JS_ReportErrorFlagsAndNumber etc so I couldn't apply it.

Comment 4

[Brendan Eich [:brendan]]

D'oh -- stand by, I'll make a branch and check in all my changes.

/be

Comment 5

[Brendan Eich [:brendan]]

Fix is in JS15_20000111_BRANCH.  Feedback welcome.

/be

Comment 6

[Robert Ginda]

testcase mentioned in url passes on branch.

Comment 7

[Robert Ginda]

... with one exception (pardon the pun):

JavaScript Error: redeclaration of var ver11
URL: file:///home/rginda/src/HTML/moztests/random.html
LineNo: 16

This is with the following in all.js:
pref("javascript.options.strict",           false);
pref("javascript.options.error_on_warn",    false);

(although I assume they're off by default.)

The error does not stop js execution.

Comment 8

[Brendan Eich [:brendan]]

Oops, spurious warning -- fixed in the JS15_20000111_BRANCH-top version of
jsinterp.c.

Rob, how does the branch look otherwise from your testsuites' p.o.v.?

/be

Comment 9

[Brendan Eich [:brendan]]

Fix landed from the JS15_20000111_BRANCH.

/be

Comment 10

[Brendan Eich [:brendan]]

So I'm closing, already!

/be

Comment 11

[rogerl (gone)]

*** Bug 22807 has been marked as a duplicate of this bug. ***

Comment 12

[Robert Ginda]

Marking Verified.

Comment 13

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/53b0964641b7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21618: Integrate Nimbus with MR2 Home Page to enable experimentation