Closed
Bug 21618
Opened 26 years ago
Closed 26 years ago
JS "var" incompatibility due to ECMA changes
Categories
(Core :: JavaScript Engine, defect, P1)
Core
JavaScript Engine
Tracking
()
VERIFIED
FIXED
M13
People
(Reporter: brendan, Assigned: brendan)
References
()
Details
(Keywords: js1.5)
Attachments
(1 file)
|
3.19 KB,
patch
|
Details | Diff | Splinter Review |
All scripts in(cluded in) a page should be treated as one JS program under ECMA
Edition 3. I busted that recently making ECMA changes for the single script tag
case. Will fix ASAP.
/be
|
Assignee | |
Updated•26 years ago
|
Status: NEW → ASSIGNED
Target Milestone: M13
|
|
Assignee | |
Updated•26 years ago
|
Priority: P3 → P1
|
|
Assignee | |
Comment 1•26 years ago
|
||
|
|
Assignee | |
Comment 2•26 years ago
|
||
Need code reviews ASAP. Thanks,
/be
|
|
||
Comment 3•26 years ago
|
||
Did you get a review on this? The attachment is missing the definition for
JS_ReportErrorFlagsAndNumber etc so I couldn't apply it.
|
|
Assignee | |
Comment 4•26 years ago
|
||
D'oh -- stand by, I'll make a branch and check in all my changes.
/be
|
|
Assignee | |
Comment 5•26 years ago
|
||
Fix is in JS15_20000111_BRANCH. Feedback welcome.
/be
|
|
||
Comment 6•26 years ago
|
||
testcase mentioned in url passes on branch.
|
|
||
Comment 7•26 years ago
|
||
... with one exception (pardon the pun):
JavaScript Error: redeclaration of var ver11
URL: file:///home/rginda/src/HTML/moztests/random.html
LineNo: 16
This is with the following in all.js:
pref("javascript.options.strict", false);
pref("javascript.options.error_on_warn", false);
(although I assume they're off by default.)
The error does not stop js execution.
|
|
Assignee | |
Comment 8•26 years ago
|
||
Oops, spurious warning -- fixed in the JS15_20000111_BRANCH-top version of
jsinterp.c.
Rob, how does the branch look otherwise from your testsuites' p.o.v.?
/be
|
|
Assignee | |
Comment 9•26 years ago
|
||
Fix landed from the JS15_20000111_BRANCH.
/be
|
|
Assignee | |
Updated•26 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 10•26 years ago
|
||
So I'm closing, already!
/be
|
|
||
Comment 11•26 years ago
|
||
*** Bug 22807 has been marked as a duplicate of this bug. ***
| Comment hidden (collapsed) |
You need to log in
before you can comment on or make changes to this bug.
Description
•