Last Comment Bug 216237 - Stopping event propagation should not cancel system event group handlers
: Stopping event propagation should not cancel system event group handlers
: fixed1.4.1
Product: Core
Classification: Components
Component: DOM: Events (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Brian Ryner (not reading)
: Hixie (not reading bugmail)
: Andrew Overholt [:overholt]
Depends on:
Blocks: 224532
  Show dependency treegraph
Reported: 2003-08-14 23:16 PDT by Brian Ryner (not reading)
Modified: 2003-11-03 01:47 PST (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

testcase (111 bytes, text/html)
2003-08-14 23:17 PDT, Brian Ryner (not reading)
no flags Details
patch (875 bytes, patch)
2003-08-14 23:18 PDT, Brian Ryner (not reading)
caillon: review+
jst: superreview+
mozilla: approval1.4.1+
mozilla: approval1.5b+
Details | Diff | Splinter Review

Description Brian Ryner (not reading) 2003-08-14 23:16:39 PDT
If you cancel an event by calling event.stopPropagation(),
event.preventBubble(), event.preventCapture(), or event.cancelBubble = true,
then we incorrectly apply that to the system event group as well.  This violates
section of the DOM3 Events spec, which says that stopping propagation in
one event group cannot affect propagation in other event groups.  Besides that,
it leads to some nasty problems, which my testcase will demonstrate.
Comment 1 Brian Ryner (not reading) 2003-08-14 23:17:18 PDT
Created attachment 129836 [details]

You should be able to type in the text field on this page, but you can't.
Comment 2 Brian Ryner (not reading) 2003-08-14 23:18:36 PDT
Created attachment 129837 [details] [diff] [review]

Clear the STOP_DISPATCH flag before beginning the second event pass.
Comment 3 Johnny Stenback (:jst, 2003-08-15 08:40:49 PDT
Comment on attachment 129837 [details] [diff] [review]

Comment 4 Brian Ryner (not reading) 2003-08-15 13:41:22 PDT
Comment on attachment 129837 [details] [diff] [review]

Can I get this in for 1.5b?  It's a pretty safe fix.
Comment 5 Mike Kaply [:mkaply] 2003-08-15 14:17:07 PDT
Comment on attachment 129837 [details] [diff] [review]

a=mkaply for trunk and branch

Thanks for finding this
Comment 6 Brian Ryner (not reading) 2003-08-15 14:42:07 PDT
Checked in on trunk and 1.4 branch.

Note You need to log in before you can comment on or make changes to this bug.